Description Dominik ölzl 2011-06-09 03:42:53 EDT

org.eclipse.swt.ole.win32.OleAutomation:

In all constructors objIDispatch.GetTypeInfo is called unnecessary .(objITypeInfo is only accessed in methods getHelpFile, getDocumentation, getPropertyDescription, getFunctionDescription, getTypeInfoAttributes and getNames which are all hardly ever used by SWT itself)

e.g.:

OleAutomation(IDispatch idispatch) {
	if (idispatch == null) OLE.error(OLE.ERROR_INVALID_INTERFACE_ADDRESS);
	objIDispatch = idispatch;
	objIDispatch.AddRef();
	
	int /*long*/[] ppv = new int /*long*/[1];
	/* GetTypeInfo([in] iTInfo, [in] lcid, [out] ppTInfo) 
	 * AddRef has already been called on ppTInfo by the callee and must be released by the caller. 
	 */
	int result = objIDispatch.GetTypeInfo(0, COM.LOCALE_USER_DEFAULT, ppv);
	if (result == OLE.S_OK) {
		objITypeInfo = new ITypeInfo(ppv[0]);
	}
}


In some cases, e.g. if calling Variant.getAutomation (which constructs a new OleAutomation instance) to an object representing an IE 9 document mode's IHTMLElement the call to GetTypeInfo costs more than one millisecond (intel i5) which causes a huge performance impact when dealing with many objects.


Solution/Workaround: Don't call GetTypeInfo in constructory but evaluate and store it when it's needed.