Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348814 - [client] Improve HTML syntax highlighting
Summary: [client] Improve HTML syntax highlighting
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 17:18 EDT by Mark Macdonald CLA
Modified: 2012-02-10 17:57 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-06-08 17:18:00 EDT 
The HTML highlighting could be improved. Some issues are:

1. Complicated DOCTYPEs are not colored
> <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

2. Attributes and quoted strings should not be colored outside of a tag
> <b>foo="bar"</b> <i>'foo'</i>

3. Entity references like &amp; are not colored
Comment 1 Mark Macdonald CLA 2011-10-20 14:40:50 EDT 
Not for 0.3
Comment 2 Mark Macdonald CLA 2012-02-02 14:28:24 EST 
I'd like to get some low-hanging improvements here for RC1
Comment 3 Mark Macdonald CLA 2012-02-10 17:57:44 EST 
#1 is fixed. The problem was that the DOCTYPE had to be on one line. Now they can span more than one line.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=32ce388e0bbe4dd8f6a96ae5cd4fa292928baad7

#2 requires some more complicated changes to how the grammar handles tags, which I'm hesitant to make in an RC. Opened 371296 to track.

#3 is fixed.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e46c245bbe0726d43a1d8ddcd287424242f1c7b9