Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348805 - Calling ResolverHook.end in failure case
Summary: Calling ResolverHook.end in failure case
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: Juno M1   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 348806 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-06-08 16:57 EDT by Thomas Watson CLA
Modified: 2011-06-09 16:09 EDT (History)
0 users

See Also:

Attachments
patch + tests (13.76 KB, patch)
2011-06-09 16:07 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-06-08 16:57:38 EDT 
The ResolverHook.end method should be called for all valid hooks instances still participating in a resolve process even if an exception was thrown from the hook.  The current implementation never calls end if there is an error that causes the resolve process to terminate unexpectedly.
Comment 1 Thomas Watson CLA 2011-06-09 16:04:41 EDT 
*** Bug 348806 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Watson CLA 2011-06-09 16:07:41 EDT 
Created attachment 197728 [details]
patch + tests

Note that this patch also fixes the issue in bug 348806 for failing a resolve operation if end() throws an exception.
Comment 3 Thomas Watson CLA 2011-06-09 16:09:05 EDT 
Patch released.