Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348789 - [editor] many keybindings are running the user agent default handler
Summary: [editor] many keybindings are running the user agent default handler
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 14:26 EDT by Felipe Heidrich CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Heidrich CLA 2011-06-08 14:26:00 EDT 
to mention a few, ctrl+s, ctrl shift k, etc

this is because quite few places (most in editorFeatures.js) are not returning true to indicate that the action should stop the default handler. this bug was brought to surface when  Bug 347875 was fixed.
Comment 1 Felipe Heidrich CLA 2011-06-08 14:27:37 EDT 
I'll release the fix soon.
Comment 2 Felipe Heidrich CLA 2011-06-08 14:52:46 EDT 
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=5f7bba4ff23ff70ce06a2af3ddbb1d15a031c770
http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?id=f90cb18499d632e69d7ba12f00c6c07fb27661fc
fixed


Susan, you probably want to check for more place where the same problem can be happening. Fixing Bug 347875 was maybe a bad idea. But lets try to go forward.
Comment 3 Felipe Heidrich CLA 2011-06-08 15:06:11 EDT 
fixed