Description Andrei Ilitchev 2011-06-08 11:28:42 EDT

Caused by: java.lang.NullPointerException
                at org.eclipse.persistence.internal.jpa.EntityManagerFactoryImpl.createEntityManagerImpl(EntityManagerFactoryImpl.java:280)
                at org.eclipse.persistence.internal.jpa.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:268)
...

EntityManagerFactoryImpl has been created without entityManagerSetupImpl:
    public EntityManagerFactoryImpl(DatabaseSessionImpl session) {
        delegate = new EntityManagerFactoryDelegate(session, this);
    }


setupImpl == null causing the exception: setupImpl == null
    protected EntityManagerImpl createEntityManagerImpl(Map properties) {
        EntityManagerSetupImpl setupImpl = delegate.getSetupImpl();
        if (setupImpl.isMetadataExpired()){
...

Suggested fix:
EntityManagerFactoryImpl uses setupImpl in just two places:
1. In createEntityManagerImpl method just check for null:
    protected EntityManagerImpl createEntityManagerImpl(Map properties) {
        EntityManagerSetupImpl setupImpl = delegate.getSetupImpl();
        if (setupImpl != null && setupImpl.isMetadataExpired()){
...

2. In refreshMetadata probably an exception should be thrown explaining that metadata can't be refreshed if the factory was created without setupImpl.

Workaround.
Derive a new class from EntityManagerSetupImpl wrapped around the user-supplied session, something like:

public class MyEntityManagerSetupImpl extends org.eclipse.persistence.internal.jpa.EntityManagerSetupImpl {
  MyEntityManagerSetupImpl(DatabaseSessionImpl session) {
    super();
    this.session = session;
    this.persistenceUnitInfo = new org.eclipse.persistence.internal.jpa.deployment.SEPersistenceUnitInfo();
  }
  public DatabaseSessionImpl deploy(ClassLoader realClassLoader, Map additionalProperties) {
    return this.session;  
}
}

Pass the session wrapped into MyEntityManagerSetupImpl to EntityManagerFactoryImpl constructor:

new EntityManagerFactoryImpl(new MyEntityManagerSetupImpl(session), new hashMap(0));