Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348748 - [server] GET on git config returns 500 when repository is in subfolder
Summary: [server] GET on git config returns 500 when repository is in subfolder
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 10:14 EDT by Malgorzata Janczarska CLA
Modified: 2012-01-19 11:44 EST (History)
2 users (show)

See Also:
malgorzata.tomczyk: review+
Szymon.Brandys: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-06-08 10:14:30 EDT 
If you clone a repository into a subfolder of a project (in opposite to a top-level folder directly in workspace) and then you'll try to get git config for it, you'll get error 500 with message:
{"HttpCode":500,"DetailedMessage":"One of setGitDir or setWorkTree must be called.","Message":"Failed to process an operation on commits for clone/file/a/client/","Severity":"Error","Code":0}
Comment 1 Piotr Janik CLA 2011-06-08 11:30:45 EDT 
Fix: https://github.com/pjanik/orion.server/tree/bug348748

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 2 Piotr Janik CLA 2011-06-09 04:39:51 EDT 
A new test added to the fix.
Comment 3 Szymon Brandys CLA 2011-06-09 05:26:32 EDT 
Fixed with 6f263d5c55081747442c2f5fdc3826674165c377.
Comment 4 Szymon Brandys CLA 2011-06-09 05:27:18 EDT 
.