Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348720 - [DND] Splitting self in shared area causes an SWTException
Summary: [DND] Splitting self in shared area causes an SWTException
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 08:42 EDT by Remy Suen CLA
Modified: 2012-05-02 10:00 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-06-08 08:42:25 EDT 
This seems to be caused by the new code from bug 348609.

1. Open an editor in your inner.
2. Drag and try to split and make a new stack in the shared area.
3. An SWTException will be thrown.

org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
	at org.eclipse.swt.widgets.Widget.getDisplay(Widget.java:582)
	at org.eclipse.e4.ui.workbench.addons.dndaddon.DnDInfo.update(DnDInfo.java:207)
	at org.eclipse.e4.ui.workbench.addons.dndaddon.DnDManager.startDrag(DnDManager.java:146)
	at org.eclipse.e4.ui.workbench.addons.dndaddon.DnDManager$1$1.dragDetected(DnDManager.java:109)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:127)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:969)
Comment 1 Remy Suen CLA 2011-10-14 14:10:06 EDT 
Got hit by this again just now on I20111011-2000.
Comment 2 Eric Moffatt CLA 2011-10-18 15:18:08 EDT 
I'll take a look...
Comment 3 Eric Moffatt CLA 2011-10-19 15:40:04 EDT 
How sporadic is this ? I've just tried (in I20111011-2000) but can't seem to repro...maybe I'm doing the steps wrong.
Comment 4 Remy Suen CLA 2011-10-20 08:31:13 EDT 
(In reply to comment #3)
> How sporadic is this ? I've just tried (in I20111011-2000) but can't seem to
> repro...maybe I'm doing the steps wrong.

It's pretty random. I don't think I was performing the steps described in comment 0 when I hit it with I20111011-2000.
Comment 5 Eric Moffatt CLA 2011-10-20 15:04:21 EDT 
I'll check again in M4...perhaps it has something to do with where the cursor is on a drop (i.e. perhaps it's on the border of the CTF or perhaps even over the 'sash'...
Comment 6 Eric Moffatt CLA 2011-12-09 13:09:48 EST 
Aggregate move to M5. Retarget to a different milestone if you wish...
Comment 7 Eric Moffatt CLA 2012-04-19 13:58:14 EDT 
commit 1b5674fe1d411594e2f708d5fe39695274e72cc1

I now check if there was only one element in the stack and don't allow a split.

There may still be edge conditions, try various operations like dragging views into the stack, splitting it and then closing the view and variants.
Comment 8 Eric Moffatt CLA 2012-05-02 10:00:22 EDT 
Verified in I20120430-1800.