Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348715 - Last element of a git commit may be >null
Summary: Last element of a git commit may be >null
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 08:19 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-01-24 17:46 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-06-08 08:19:31 EDT 
For some commits the last file context included in a commit may be display as "> null"
to reproduce the problem:

1) Add the following commit to a review
    2011-May-02, 12:24:45 on project org.eclipse.jgit, id: b2b58feba...
2) close and open the review

3) See the last element as ">null" and see in properties, the target file is not populated, the path in the base file is not populated either.
Comment 1 Sebastien Dubois CLA 2011-06-10 15:12:45 EDT 
The problem was that we were only checking the name in EditorProxy#findReusableCompareEditor.  We now check if the file revision objects are matching.  This should fix the problem