Comment 1 Eric Moffatt 2011-06-08 09:40:40 EDT

Sabine, I suspect that this defect is in the wrong component area...'e4' is the foundation for the new eclipse 4.x functionality which has no connection to the 'pushingpixels' project (but I like the name..;-).

Comment 2 Sabine Achilles 2011-06-08 09:46:50 EDT

Hi Eric,

since the bundle is hosted in the e4 CVS repository under e4/org.eclipse.e4.ui/bundles/org.pushingpixels.trident I thought this would be exactly the right place for this bug. If not, please tell me where to open a bug for this.
And yes, the name is quite fitting :)

Thanks,
Sabine

Comment 3 Christian Campo 2011-06-08 10:31:38 EDT

Eric, we are distributing trident pushingpixels which is an original CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3626 from e4.

Its hosted at /cvsroot/eclipse e4/org.eclipse.e4.ui/bundles/org.pushingpixels.trident

That bundle is missing the about.html file with the license (BSD). Riena has a piggyback on that and is distribution trident as part of its own distriution.

So we just kindly ask that you add the about.html and maybe put a tag on this version or include the about.html in the existing tag so that we can consume it.

thanls

christian campo

Comment 4 Christian Campo 2011-06-08 10:33:08 EDT

sorry I didnt see that Sabine already replied. So probably best to ignore my comments. :-)

Comment 5 John Arthorne 2011-06-08 15:10:13 EDT

I have added the legal files and tagged as version v20110608.

I don't think we actually build this bundle ourselves right now, so I'm unable to verify the fix.

Comment 6 Eric Moffatt 2011-06-08 16:16:00 EDT

Thanks John.

Comment 7 Christian Campo 2011-06-08 16:52:45 EDT

(In reply to comment #5)
> I have added the legal files and tagged as version v20110608.
> 
> I don't think we actually build this bundle ourselves right now, so I'm unable
> to verify the fix.

thanks….

yes Riena build checks it out and builds it. So we can verify that and reopen that bug if it happens again.

Comment 8 Sabine Achilles 2011-06-09 03:39:48 EDT

Thank you very much!

Comment 9 Christian Campo 2011-06-14 10:54:46 EDT

Created attachment 197958 [details]
BSD-2 license about.html

Comment 10 Christian Campo 2011-06-14 11:03:45 EDT

I think the bug is still not fixed, John.

You checked in an EPL license in about.html which I dont think is what this lib is. The CQ says its BSD. So I have created such an about.html that I believe is correct. Please check and modify the about.html in CVS (and create a tag).

Not critical for Indigo, since I will just modify the about.html file directly in my artifact before I upload it.

Comment 11 John Arthorne 2011-06-14 13:01:54 EDT

This is the standard about.html format used for bundles containing third party content. The bundle is actually provided by the Eclipse foundation, but contains third party content that is under different license. My about.html says all that, and indicates the Trident library is licensed under BSD. I also included a copy of the specific BSD license text in about_files/license.txt. I have read through my about.html again I believe it correctly follows the template set out by Eclipse Legal. I'm marking as FIXED again.

[1] http://eclipse.org/legal/epl/about.php