Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348643 - Open discussion on R4E Naming conflict
Summary: Open discussion on R4E Naming conflict
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-07 16:51 EDT by Sebastien Dubois CLA
Modified: 2012-01-24 15:35 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Dubois CLA 2011-06-07 16:51:33 EDT
As we move closer to releasing the open source R4E, there is a potential naming conflict for R4E between the internal non-open source legacy version and the new open source R4E that is part of Mylyn reviews.  The problem is that both are named the same, so we have a name collisions for e.g. R4E Context menus, Preferences, View Names, And View Folders.

There are multiple ways of handling this:

-Rename the new open source R4E menus to something else.  Suggestions include:  R4Eclipse, Open R4E, Reviews, Reviews>R4E.
-Rename the Legacy R4E to something else e.g. Legacy R4E, R4Ericsson.
-Keep the same names, but prevent both version to be installed under the same Eclipse installation.
-Keep everything as is, but document the name collision thouroughly for existing users.

We understand that this is mainly an internal issue to Ericsson, but wanted to bring up the issue to ask for opinions, advice etc.  Take note that this issue will be temporary, as the Legacy R4E will be phased out while the new open source R4E is phased in.  Nonetheless, both version will co-exist for some time so action is needed.

I'm filing this bug to start a discussion on how we can make sure that both R4E versions can co-exist without confusing existing users, ideally by keeping the same names, or worst-case by modifying them to the least extent possible.
Comment 1 Steffen Pingel CLA 2011-06-09 10:24:05 EDT
It sounds as if R4E is a recognized name already and the Eclipse R4E is a continuation of the closed source tool which will replace the latter over time. Also, R4E is already used in namespaces, documentation etc. at Eclipse. It could still be changed at a cost but I wonder if there is a need. To distinguish I have seen other companies prefixing the name with Eclipse, e.g. Eclipse Birt vs. Birt (the closed source variant) which could work for R4E as well.

In the past, we have disabled features programmatically when detecting that another feature is already installed or through shipping a higher version of an existing feature that is essentially empty.
Comment 2 Sebastien Dubois CLA 2011-06-09 10:30:55 EDT
(In reply to comment #1)
> It sounds as if R4E is a recognized name already and the Eclipse R4E is a
> continuation of the closed source tool which will replace the latter over time.
> Also, R4E is already used in namespaces, documentation etc. at Eclipse. It could
> still be changed at a cost but I wonder if there is a need. To distinguish I
> have seen other companies prefixing the name with Eclipse, e.g. Eclipse Birt vs.
> Birt (the closed source variant) which could work for R4E as well.
> 

Yes that could be a way.

> In the past, we have disabled features programmatically when detecting that
> another feature is already installed or through shipping a higher version of an
> existing feature that is essentially empty.

  The main problem really is that the Context menu and view folders names are the same, the rest could be handled internally.   We need to have both plugins working at the same time, as they are not compatible to each other and there will be a transition period where a given user could use both the closed and open R4E at the same time.
Comment 3 Steffen Pingel CLA 2011-06-09 13:23:22 EDT
Another option that you could consider are Capabilities which allow dynamic hiding of UI contributions. Some documentation is available on the Eclipse Wiki (search for capabilities or activities) and we have some sample extensions in the org.eclipse.mylyn.incubator/org.eclipse.mylyn.ide.capabilities bundle: http://wiki.eclipse.org/Mylyn/Integrator_Reference#Capabilities .
Comment 4 Sebastien Dubois CLA 2011-06-13 12:31:25 EDT
Ok I introduced capabilities for R4E so that the UI contribution can be enabled/disabled using the Preferences->General->Capabilities.  I also updated the online documentation to reflect this.

Now what's left to be done is to change the legacy code to also use capabilities.  I'll assign this to Jacques so that he can do it for the next legacy release.
Comment 5 Sebastien Dubois CLA 2011-06-27 12:58:03 EDT
I will close this bug and Jacques will open a new one for the Legacy R4E