Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348600 - [client][git] Push command doesn't display on git log when repo is in subfolder
Summary: [client][git] Push command doesn't display on git log when repo is in subfolder
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 349195 349289
Blocks:
  Show dependency tree
 
Reported: 2011-06-07 11:40 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:
Szymon.Brandys: review+

Attachments
git-log.js changes (4.10 KB, patch)
2011-06-13 10:46 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
gitCommands.js changes (1.23 KB, patch)
2011-06-13 10:46 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-06-07 11:40:50 EDT 
Yet another problem with repositories in subfolders. This time in UI.
We assumed that Push command on git log should be visible only if we are displaying git log for the top folder of the repository. So far UI assumed that repositories may be located only in workspace top folders and displayed the Push command based on this knowledge. But now when we can have the repository top folder in the subfolder we can't use this assumption any more. We need something more reliable.

Any ideas how can I distinguish between a main folder of the repository and its subfolder?
Comment 1 Tomasz Zarna CLA 2011-06-07 12:02:26 EDT 
(In reply to comment #0)
> Any ideas how can I distinguish between a main folder of the repository and its
> subfolder?

You could compare CloneLocation and your current Location. If they differ it means you're not in a root of a git repository.
Comment 2 Tomasz Zarna CLA 2011-06-07 12:05:14 EDT 
btw, have a look at bug 344746.
Comment 3 Malgorzata Janczarska CLA 2011-06-13 10:46:00 EDT 
Created attachment 197889 [details]
git-log.js changes
Comment 4 Malgorzata Janczarska CLA 2011-06-13 10:46:31 EDT 
Created attachment 197890 [details]
gitCommands.js changes
Comment 5 Malgorzata Janczarska CLA 2011-06-13 10:47:51 EDT 
I added a fix that requires support for deferred on visibleWhen, so I'm waiting for review on bug 349195, then it will have sense to push this changes.
Comment 6 Malgorzata Janczarska CLA 2011-06-15 04:55:13 EDT 
done