Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348551 - [server][git] Branch.CommitLocation and Remote.CommitLocation should accept the parameter pageSize.
Summary: [server][git] Branch.CommitLocation and Remote.CommitLocation should accept t...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 345978 345980 345981
  Show dependency tree
 
Reported: 2011-06-07 08:53 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-01 11:43 EDT (History)
3 users (show)

See Also:
tomasz.zarna: review+

Attachments
Change for review (2.18 KB, patch)
2011-06-07 13:02 EDT, Malgorzata Janczarska CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-06-07 08:53:59 EDT 
Page size for commit list obtained by Branch.CommitLocation and Remote.CommitLocation should allow to change pageSize.
Comment 1 Malgorzata Janczarska CLA 2011-06-07 13:02:32 EDT 
Created attachment 197522 [details]
Change for review

I'm attaching a small change that uses pageSize when provided. Otherwise it uses the default size witch is currently 50.
Comment 2 Tomasz Zarna CLA 2011-06-08 05:32:12 EDT 
Looks good, a test case double checking if the new param works would be great though.
Comment 3 Malgorzata Janczarska CLA 2011-06-08 06:36:20 EDT 
I added test case and pushed changes.

Libing, you can try now "?page=1&pageSize=5" instead of "?page=1".