Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348494 - Missing dijit dependencies in orion components
Summary: Missing dijit dependencies in orion components
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-07 01:15 EDT by Simon Kaegi CLA
Modified: 2011-09-01 11:42 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-06-07 01:15:15 EDT 
While single stepping through generateBanner (experimenting with auth) I was getting errors when accessing dijit widgets where we had missing dependencies.

The following need to be added:
'dijit/Menu'
'dijit/MenuItem'
'dijit/form/DropDownButton'
Comment 1 Simon Kaegi CLA 2011-06-07 01:26:01 EDT 
Also found the following missing from commands.js:
'dijit/MenuItem'
'dijit.PopupMenuItem'
'dijit/MenuSeparator'
Comment 2 Simon Kaegi CLA 2011-06-07 01:38:50 EDT 
...and in compare-features.js, util.js, and git-status-table.js.

These changes are just adding dependencies and are binary (they either work or fail immediately) 

I've tested and am going to push to HEAD so these are in the 2am build.
Comment 3 Simon Kaegi CLA 2011-06-08 11:47:47 EDT 
Fixed in HEAD.