Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348445 - Remove NON-NLS from "View Menu" string
Summary: Remove NON-NLS from "View Menu" string
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 13:53 EDT by Carolyn MacLeod CLA
Modified: 2012-01-30 17:25 EST (History)
2 users (show)

See Also:

Attachments
Localization patch v1 (3.34 KB, patch)
2011-06-28 08:45 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2011-06-06 13:53:59 EDT 
Build id: I20110604-2201

In the method: org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.showMenuButton(MPart, CTabFolder, MMenu)
in the following line of code:
  ti.setToolTipText("View Menu"); //$NON-NLS-1$
the string "View Menu" *should* be NLS'ed.

If there is anything that depends on that string, the dependent code should be rewritten.
Comment 1 Remy Suen CLA 2011-06-28 08:45:09 EDT 
Created attachment 198715 [details]
Localization patch v1

Patch to the externalize the string so that it can be translated.
Comment 2 Remy Suen CLA 2011-06-28 08:46:47 EDT 
(In reply to comment #1)
> Created attachment 198715 [details]
> Localization patch v1

Fix released to CVS HEAD.

Thanks for finding this problem, Carolyn!
Comment 3 Remy Suen CLA 2012-01-30 17:25:17 EST 
Verified by source inspection with I20120127-1145 on Windows 7.