Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348405 - preferences.js restructuring to support jsdoc
Summary: preferences.js restructuring to support jsdoc
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 10:38 EDT by John Arthorne CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:
simon_kaegi: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-06-06 10:38:22 EDT 
In order to get documentation of preferences.js working I had to convert to using prototypes. Although this is essentially a doc change I would like someone to take a look at the result to double-check it.
Comment 1 John Arthorne CLA 2011-06-06 15:37:32 EDT 
Simon please take a look. Looking at the diff is useless because the entire file has changed. I have pushed it to this branch:

refs/remotes/origin/20110606-prefs-refactor
Comment 2 Simon Kaegi CLA 2011-06-07 22:38:24 EDT 
Thanks John. Looks good and have pushed. I had a conflict and had to do the merge but tried to amend the author. Hopefully I got it right.