Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348399 - [client] Optimize templates properly
Summary: [client] Optimize templates properly
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 10:19 EDT by Simon Kaegi CLA
Modified: 2011-09-01 11:41 EDT (History)
1 user (show)

See Also:
john.arthorne: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-06-06 10:19:41 EDT 
We (as well as  dojo and dijit) currently use the requirejs "text" plugin to inline our templates but are not making use of them at runtime. This is a known problem with a workaround that we should enable as it will save us approximately 175ms per page in my testing.
Comment 1 John Arthorne CLA 2011-06-06 10:20:44 EDT 
I reviewed this change.
Comment 2 Simon Kaegi CLA 2011-06-06 10:25:21 EDT 
To add some detail...
I had this change ready in a branch and associated with bug 345483 however was concerned about the build and testing so did not release for M8.

John reviewed but we need a test build to verify everything is in good shape before closing.
Comment 3 Simon Kaegi CLA 2011-06-07 10:47:13 EDT 
Looks good now. Marking fixed.
Mark reviewed a final change in how we handled the templates for dijit tooltip.js.