Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348370 - Save does not work anymore by default, need to use a gmf globalAction
Summary: Save does not work anymore by default, need to use a gmf globalAction
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: 2.4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 346648
  Show dependency tree
 
Reported: 2011-06-06 05:22 EDT by Aurelien Pupier CLA
Modified: 2011-07-14 07:51 EDT (History)
2 users (show)

See Also:

Attachments
add IgraphicalEdipart to react to globalActionId "save" (987 bytes, patch)
2011-06-06 05:22 EDT, Aurelien Pupier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aurelien Pupier CLA 2011-06-06 05:22:59 EDT 
Created attachment 197379 [details]
add IgraphicalEdipart to react to globalActionId "save"

Save does not work anymore by default, need to use a gmf globalAction in combination with the patch provided on bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=346648
Comment 1 Mickael Istria CLA 2011-06-06 07:51:03 EDT 
Just tried this patch and tests are still working well. It solves the "save" issue in the case of a selection change, and it is the only thing to modify in GMF Tooling.
Then I commit it.
Comment 2 Mickael Istria CLA 2011-06-06 08:11:04 EDT 
Committed
Comment 3 Mathieu Velten CLA 2011-06-06 08:26:01 EDT 
the most important part (for us at least) that allows the save action to react to property changes (like a move of a graphical element) has not been committed, is it normal ?

link to the patch :
https://bugs.eclipse.org/bugs/attachment.cgi?id=197081

we would really like to have this committed before indigo release, the tooling patch you committed can be easily "workarounded" manually, this one is not.

thanks.
Comment 4 Mickael Istria CLA 2011-06-06 08:27:42 EDT 
The patch for the property changed listener is not part of GMF-Tooling. It is part of GMF-Runtime. Bug #346648 tracks the Runtime part.
Comment 5 Michael Golubev CLA 2011-07-13 19:45:51 EDT 
version -> 2.4
Comment 6 Michael Golubev CLA 2011-07-14 07:51:37 EDT 
Rollback, Set target to 2.4 instead of accidenatlly set Version