Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348348 - focus filter sticks when FocusTaskList action runs twice
Summary: focus filter sticks when FocusTaskList action runs twice
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.6   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 339777
Blocks:
  Show dependency tree
 
Reported: 2011-06-05 18:01 EDT by Steffen Pingel CLA
Modified: 2011-06-06 11:31 EDT (History)
2 users (show)

See Also:

Attachments
fix (3.19 KB, patch)
2011-06-06 11:08 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (36.50 KB, application/octet-stream)
2011-06-06 11:08 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-06-05 18:01:42 EDT 
This problem was introduced by the changes made for bug 339777. TaskListFocusAction can get into a state when uninstallInterestFilter() does not remove the interest filter resulting in a Task List that is always focused.
Comment 1 Steffen Pingel CLA 2011-06-06 11:08:44 EDT 
Created attachment 197406 [details]
fix
Comment 2 Steffen Pingel CLA 2011-06-06 11:08:47 EDT 
Created attachment 197407 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2011-06-06 11:10:39 EDT 
Steps:
1. Focus Task List
2. Activate Task that has a stack trace
3. Unfocus Task List

The focus filter is still active even though the task list is unfocused. This is due to the viewer initialization in ContextPopulationStrategy.populateContext() which causes FocusTaskListAction.installInterestFilter() to get invoked twice which causes the interest filter to get added to previousFilters and previousSorter to get set to an unexpected sorter.
Comment 4 Steffen Pingel CLA 2011-06-06 11:31:56 EDT 
Fix applied to head and e_3_7_m_3_6_x branch.