Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348185 - [documentation] Do not distribute eclipse.xsl
Summary: [documentation] Do not distribute eclipse.xsl
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: OCL Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 05:27 EDT by Ed Willink CLA
Modified: 2013-05-20 11:35 EDT (History)
1 user (show)

See Also:
Kenn.Hussey: pmc_approved+

Attachments
Remove stylesheets and build script from doc sources (620 bytes, patch)
2011-06-03 05:29 EDT, Ed Willink CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-06-03 05:27:23 EDT 
The XSL stylesheets used to prepare the OCL documentation were all taken from Xtext CVS. While failing to fix a < bug for toc.xml, I noticed that eclipse.xsl has:

     This file is part of the XSL DocBook Stylesheet distribution.
     See ../README or http://docbook.sf.net/release/xsl/current/ for
     copyright and other information.

MDT/OCL has no piggyback CQ for this and it is unclear whether any project has a primary CQ; Xtext hasn't but no longer uses this file. I am investigating with Mylyn Docs.

The http://docbook.sf.net/release/xsl/current/COPYING is extremely lenient so the problem is trivial.

Nonetheless it would seem prudent not to distribute a file with the above text by removing the stylesheets from the org.eclipse.ocl.doc.source plugin until this issue has been resolved.
Comment 1 Ed Willink CLA 2011-06-03 05:29:49 EDT 
Created attachment 197295 [details]
Remove stylesheets and build script from doc sources
Comment 2 Adolfo Sanchez-Barbudo Herrera CLA 2011-06-03 05:48:07 EDT 
I know we need two PMCs votes, but the patch it looks like good to me.

+1
Comment 3 Ed Willink CLA 2011-06-04 04:59:56 EDT 
Given the strength of Kenn's +1. I've taken it as

+1 from PMC
+1 from IP policy

and have committed to HEAD for RC4. (The file was only ever in the RC3 doc.sources.)
Comment 4 Ed Willink CLA 2011-08-23 16:06:11 EDT 
Fix was in Indigo build.
Comment 5 Ed Willink CLA 2013-05-20 11:35:18 EDT 
CLOSED after a year in the RESOLVED state.