Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348182 - Query2 Incompatiblity with Xtext2.0
Summary: Query2 Incompatiblity with Xtext2.0
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: RC4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 05:21 EDT by saurav sarkar CLA
Modified: 2017-09-19 17:10 EDT (History)
3 users (show)

See Also:
jan: indigo+

Attachments
Contains the screenshot for the incompatiblity list (146.13 KB, image/pjpeg)
2011-06-03 05:21 EDT, saurav sarkar CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description saurav sarkar CLA 2011-06-03 05:21:59 EDT 
Created attachment 197294 [details]
Contains the screenshot for the incompatiblity list

Hi All,

Query2's String syntax feature depends on XText.
With the advent of XText2.0 we few problems.

I have attached the screenshot for the incompatiblities which we have found.
I have also done an intital analysis for them.Like IUnitOfWork's package has been changed to org.eclipse.xtext.util.concurrent .

So this kind of migration we can do from our side.

But i also see lots of class access has been restricted and some Outline API restructuring.We would need help on these resolving those kind of issues.

Please provide your comments/suggestions on this.Let me know if the attachement is not clear.

cheers,
Saurav
Comment 1 Sven Efftinge CLA 2011-06-03 05:40:14 EDT 
Could you please provide the list of incompatibilities as plain text in a comment.
The outline has been redesigned. The new outline API is described in the Help.
The RC4 will contain a migration guide covering other changes.

Regarding the restricted access. This is how we communicate what's API and what is not.
It doesn't mean you can't use non API, it is just that the next release might not be a drop-in replacement if you use any of the provisional APIs.
Comment 2 saurav sarkar CLA 2011-06-03 05:59:22 EDT 
(In reply to comment #1)
> Could you please provide the list of incompatibilities as plain text in a
> comment.
> The outline has been redesigned. The new outline API is described in the Help.
> The RC4 will contain a migration guide covering other changes.
> Regarding the restricted access. This is how we communicate what's API and what
> is not.
> It doesn't mean you can't use non API, it is just that the next release might
> not be a drop-in replacement if you use any of the provisional APIs.

Hi Sven,

Please find the list below

(a)The method allInResource is removed now from the Scopes class.

(b) The ParseTree package is not made accessible to any other plug-in.We used to use AbstractNode,CompositeNode,ParseTreeUtil,NodeUtil classes from that package.

(c) org.eclipse.xtext.util.TextLocation not available. 
(d) ILocationInFileProvider.getLocation(Eobject object) is not available.   

(e) org.eclipse.xtext.ui.editor.outline.transformer is not exposed.We used AbstractDeclarativeSemanticModelTransformer.

(g) org.eclipse.xtext.ui.editor.syntaxcoloring.antlr is not exposed.Generated UI module used AntlrTokenScanner.

Furthermore i will check the outline APIs in the help.

cheers,
Saurav
Comment 3 Jan Koehnlein CLA 2011-06-03 10:34:19 EDT 
I've updated the migration guide. All your points should be covered, except from (a) which had already been deprecated. Please use a SimpleLocalScopeProvider instead.
Comment 4 Ashwani Kr Sharma CLA 2011-06-05 21:57:57 EDT 
Hi Jan,

From where can we access the migration guide ?

Regards,
Ashwani Kr Sharma
EMF Query2 Committer
Comment 6 Karsten Thoms CLA 2017-09-19 16:58:48 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 7 Karsten Thoms CLA 2017-09-19 17:10:04 EDT 
Closing all bugs that were set to RESOLVED before Neon.0