Description Bin Feng 2011-06-02 22:33:10 EDT

Build Identifier: DTP_1_8_2

org.eclipse.datatools.connectivity.sqm.core.rte.jdbc.JDBCDatabase does not override super class DatabaseImpl method getSchemas(). This cause org.eclipse.datatools.modelbase.sql.query.helper.DatabaseHelper.findSchema(Database database, String schemaName) line#210 "database.getSchemas()" return empty schemas list; Then method DatabaseHelper.findSchema() have to run into supplemental schema loading logic and get all schemas from all catalogs.
The supplemental schema loading logic works fine for Oracle, MySQL, Derby, UDB correctly. But the logic does not work well for MSSQL and SYBASE ASE, because execution DatabaseMetaData.getCatalogs() against these databases also returns catalogs for system databases "master", "msdb", "tempdb"; each system database catalogs can have same schema names "dbo"; This finally results DatabaseHelper.findSchema() find an incorrect schema. 
Method org.eclipse.datatools.sqltools.sqlbuilder.model.DatabaseHelper.getSchemaList(Database database) also has the same problem. This cause multiple schemas with the same schema name (but belongs to different catalogs) are returned by DatabaseHelper.getSchemaList().

To fix the problem, please add schema loading logic to JDBCDatabase.getSchemas().

Reproducible: Always

Steps to Reproduce:
The problem can be reproduced in BIRT env.
1. Create a BIRT report, add a "JDBC Database connection for Query Builder" and choose connection profile type "SQL Server".
2. Create a dataset for the datasource, "SQL select query" right click and select "Add tables" menu item. In the popup "table selection" dialog, multiple schemas with the same schema name are displayed; But actually they are belong to different catalogs. 
Expected result: schemas belong to the specified database are displayed.