Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348153 - Commit amend ignores existing change-id from previous commit
Summary: Commit amend ignores existing change-id from previous commit
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 1.0.0   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 19:31 EDT by Matthias Sohn CLA
Modified: 2011-06-04 20:09 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Sohn CLA 2011-06-02 19:31:26 EDT 
used EGit 1.0.0.201106011211-rc3	and 3.6 SR2 SDK

- start from a project with at least one commit containing a Gerrit change-id
- modify a file which is already in the repository
- Team > Commit, click "Amend"
- the commit dialog generates a fresh change-id template (I0000..), instead it should leave the existing change-id from the commit to be amended untouched.

the following scenario works as expected:
- start from a commit containing a change-id
- from clean working tree click Team > Commit
- accept to amend, this time the old change-id remains untouched
Comment 1 Stefan Lay CLA 2011-06-03 06:33:23 EDT 
This bug was introduced by 4347a21fa0e7c1979839ea4fb7.

I can reproduce it on Windows 7.
Comment 2 Dariusz Luksza CLA 2011-06-04 20:09:13 EDT 
Fix merged as commit 29f005e40ff25bf6d53f76d31e18018762c4c0f8
Comment 3 Dariusz Luksza CLA 2011-06-04 20:09:39 EDT 
Fix merged as commit 29f005e40ff25bf6d53f76d31e18018762c4c0f8