Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348137 - [client] [textmatestyler] Change that affects no regions should be fast
Summary: [client] [textmatestyler] Change that affects no regions should be fast
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 16:07 EDT by Mark Macdonald CLA
Modified: 2015-05-05 14:52 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-06-02 16:07:10 EDT 
If you make a change to a file and there are no begin..end regions at all, the repairer is degrading to worst-case behaviour (ie. parsing the whole file again).

Since no begin..end regions are affected, only the line(s) you actually changed should be considered damaged, and nothing more needs to be re-parsed.
Comment 1 Mark Macdonald CLA 2011-06-06 12:05:52 EDT 
This has improved: it no longer parses the whole file again. But I think it's still doing more than it needs to.
Comment 2 Mark Macdonald CLA 2011-06-10 12:33:16 EDT 
The performance has been acceptable so far. Will investigate further after 0.2
Comment 3 John Arthorne CLA 2015-05-05 14:52:20 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html