Community
Participate
Working Groups
When I merged the publisher changes back in head, I overlooked the detail on the format on disk and it resulted that it is a folder instead of being a jar like the publisher was. This seems to cause issues to the Virgo build that can't deal with the inner jars. Given that this was an accident, I'll fix it.
Virgo build issues are actually caused by the fact that classes in the inner jar cannot be referred to from outside the publisher jar/folder at compile time. So Virgo components which use publisher classes fail to compile. In that sense having jar instead of folder won't solve the issues if the inner jar remains as it is. It would be helpful if the new publisher jar has similar file structure to 3.7M6 org.eclipse.equinox.p2.publisher_1.2.0.v20110228.jar for example (directly containing class files rather than pdepublisher.jar).
Fixed in HEAD. ### Eclipse Workspace Patch 1.0 #P org.eclipse.equinox.p2.publisher.eclipse Index: META-INF/MANIFEST.MF =================================================================== RCS file: /cvsroot/rt/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.publisher.eclipse/META-INF/MANIFEST.MF,v retrieving revision 1.2 diff -u -r1.2 MANIFEST.MF --- META-INF/MANIFEST.MF 1 Apr 2011 17:32:23 -0000 1.2 +++ META-INF/MANIFEST.MF 12 Jun 2011 04:24:39 -0000 @@ -2,8 +2,6 @@ Bundle-ManifestVersion: 2 Bundle-Name: %bundleName Bundle-SymbolicName: org.eclipse.equinox.p2.publisher.eclipse;singleton:=true -Bundle-ClassPath: pdepublishing.jar -Eclipse-BundleShape: dir Bundle-Version: 1.0.0.qualifier Bundle-Activator: org.eclipse.pde.internal.publishing.Activator Bundle-ActivationPolicy: lazy
*** Bug 350076 has been marked as a duplicate of this bug. ***
This bundle is still in bad shape. It is still a directory, but instead of the nested pdepublishing.jar, the class files are directly on disk. We likely need to update the feature and/or put Eclipse-BundleShape:jar
Created attachment 198474 [details] patch
Ok, this should do it.
