Description Patrick Tasse 2011-06-01 17:20:14 EDT

Build Identifier: 

Submitting a patch to fix a resource leak in the Colors view.

The Colors view is used to manage color settings used by the events table. The ColorSetting object contains four Color resource instances which must be disposed when no longer required. When the user deletes a color setting in the Colors view, or overwrites color settings during an import action, the Color resources held by the color setting are never disposed.

The solution is to implement a dispose() method in the ColorSetting class, and invoke it whenever the color setting is no longer needed.

Reproducible: Always

Steps to Reproduce:
0. Run in Debug mode and put a breakpoint in the Color(Resource) constructors and dispose() method
1. In the Colors view, add a color setting
2. Observe that four Color instances are created
3. Export the color setting to file
4. Delete the color setting
5. Observe that the Color instances are not disposed as required by their API
6. Add a new color setting
7. Import the color setting exported in step 3
8. Choose Yes to overwrite the current color settings
9. Observe that the new color setting Color instances are not disposed