Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347990 - [TMF] Incorrect handling of preview table in custom parser wizards
Summary: [TMF] Incorrect handling of preview table in custom parser wizards
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301610
  Show dependency tree
 
Reported: 2011-06-01 14:22 EDT by Patrick Tasse CLA
Modified: 2022-01-13 14:52 EST (History)
0 users

See Also:


Attachments
Proposed patch in org.eclipse.linuxtools.tmf.ui package (3.00 KB, patch)
2011-06-01 14:23 EDT, Patrick Tasse CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tasse CLA 2011-06-01 14:22:06 EDT
Build Identifier: 

Submitting a patch to correct the handling of the preview table in the custom parser wizards (Text and XML).

The second page of the wizard contains a preview table. The number of items in the table is arbitrarily set to 50, to limit the number of rows in the preview table. In earlier code this worked correctly, but in the latest code, if the parsed preview text contains less than 50 events, the table keeps trying to fetch the row data, in some case resulting in "too many files open" exceptions.

The solution is simply to remove the brute force setting of the number of items in the table. The trace indexing is automatically triggered in the trace constructor and this will fill the table properly. The number of parsed events in the preview table is no longer limited.

Reproducible: Always

Steps to Reproduce:
1. Open the Manage Custom Parsers dialog in the TMF > Projects view.
2. Click New... to open the wizard.
3. Fill the first page with enough data to be able to click Next...
4. In the second page click Finish
Comment 1 Patrick Tasse CLA 2011-06-01 14:23:23 EDT
Created attachment 197131 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2012-09-06 18:00:54 EDT
This change was committed with bug 353020 and delivered in 0.9.0.
Comment 3 Jeff Johnston CLA 2012-09-28 13:42:29 EDT
Comment on attachment 197131 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Functionality applied in another bug.