Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347983 - [UI] Splitting a DW no longer works
Summary: [UI] Splitting a DW no longer works
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.1 RC4   Edit
Assignee: Project Inbox CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
: 347561 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-06-01 13:57 EDT by Eric Moffatt CLA
Modified: 2011-06-06 09:52 EDT (History)
2 users (show)

See Also:
remy.suen: review+

Attachments
Disable the 'outerDock' behavior if the stack is not under an MArea or MPerspective (3.07 KB, patch)
2011-06-01 13:58 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-06-01 13:57:10 EDT 
This was introduced during the changes for bug 341009. The code to detect an 'outerDock' should only be used if the given 'dropStack' is inside either an MArea or MPerspective...
Comment 1 Eric Moffatt CLA 2011-06-01 13:58:30 EDT 
Created attachment 197122 [details]
Disable the 'outerDock' behavior if the stack is not under an MArea or MPerspective
Comment 2 Eric Moffatt CLA 2011-06-01 14:00:29 EDT 
Remy, can you please review the patch ?
Comment 3 Eric Moffatt CLA 2011-06-01 14:21:00 EDT 
*** Bug 347561 has been marked as a duplicate of this bug. ***
Comment 4 Remy Suen CLA 2011-06-01 14:37:06 EDT 
(In reply to comment #1)
> Created attachment 197122 [details]
> Disable the 'outerDock' behavior if the stack is not under an MArea or
> MPerspective

Looks okay to me.

Please open a new bug so that the "outer dock" behaviour is enabled and brought back for detached windows in 4.2.
Comment 5 Eric Moffatt CLA 2011-06-01 15:09:47 EDT 
Committed in >20110601. Applied the patch.
Comment 6 Paul Webster CLA 2011-06-02 12:36:40 EDT 
bug 348078 might be related to this.  To confirm.

PW
Comment 7 Eric Moffatt CLA 2011-06-06 09:52:28 EDT 
Verified in I20110604-2201.