Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347977 - Exception in error log while renaming entity
Summary: Exception in error log while renaming entity
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Stefan Dimov CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 12:44 EDT by Stefan Dimov CLA
Modified: 2011-08-12 10:32 EDT (History)
2 users (show)

See Also:
stefan.dimov: review+

Attachments
fix (1.15 KB, patch)
2011-06-01 12:46 EDT, Stefan Dimov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Dimov CLA 2011-06-01 12:44:19 EDT 
While renaming entity everything works fine, but an exception is being logged in the error log. It's because the old resource is not being successfully saved
Comment 1 Stefan Dimov CLA 2011-06-01 12:46:14 EDT 
Created attachment 197115 [details]
fix
Comment 2 Stefan Dimov CLA 2011-06-01 12:54:25 EDT 
This is not a real error, but it would create a bad impression in the user that's why it's good to be fixed.

No workaround.

The fix was tested manually and all the exisitng JUnit tests are passing successfully.

The exception is being logged during trial to save of non-existing resource. Actually everything is fine. The fix just ignores the exception when the corresponding resource is not accessible anymore.

The risk is low, because the fix is very small and doesn't change the existing functionality. It just ignores the exception in some cases.
Comment 3 Neil Hauge CLA 2011-06-01 13:07:42 EDT 
I agree that this looks bad, but given the lower severity, probably not a candidate for RC4, even though the fix risk is low.
Comment 4 Stefan Dimov CLA 2011-06-01 13:28:50 EDT 
Ok ... it was worth trying :) Perhaps 3.0.1?
Comment 5 Neil Hauge CLA 2011-06-01 13:59:58 EDT 
(In reply to comment #4)
> Ok ... it was worth trying :) Perhaps 3.0.1?

Certainly!
Comment 6 Stefan Dimov CLA 2011-06-27 10:21:46 EDT 
patch submitted in R3_0_maintenance
Comment 7 Stefan Dimov CLA 2011-06-27 10:22:30 EDT 
Patch also submitted in HEAD
Comment 8 Jolene Moffitt CLA 2011-08-12 10:32:31 EDT 
Verified in Build I-3.4.0-20110805150738 

Verified no error appears in the error log when you rename the entity name in the diagram editor.  See the link to view test steps for verification.
http://wiki.eclipse.org/Dali_3.0.1