Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347976 - Update EMF Transaction and Validation versions
Summary: Update EMF Transaction and Validation versions
Status: RESOLVED FIXED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: 3.10   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.10.0   Edit
Assignee: Tran Le CLA
QA Contact: David Williams CLA
URL:
Whiteboard: PMC
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 12:42 EDT by Neil Hauge CLA
Modified: 2018-06-29 15:30 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved+
neil.hauge: pmc_approved? (kaloyan)
neil.hauge: pmc_approved? (cbridgha)


Attachments
Proposed patch (2.49 KB, patch)
2011-06-01 17:52 EDT, Tran Le CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hauge CLA 2011-06-01 12:42:09 EDT
The secondary Dali dependencies (EMF Transaction and Validation) need to be updated to their Indigo versions (1.5.0).  This should be done to align with what will be installed from the Indigo repository when the JPA Diagram Editor is selected.  Graphiti 0.8 requires versions 1.4 or higher of these dependencies, so 1.5 is a valid and preferred option.
Comment 1 Neil Hauge CLA 2011-06-01 12:44:31 EDT
David...let me know how you want to precede with this.  Tran can make the changes, but wasn't sure if you wanted to do a build for this, or edit the website.  I assume build, but thought I would ask.  PMC approval would be requested for any change.
Comment 2 David Williams CLA 2011-06-01 13:00:58 EDT
Yeah, I think we should rebuild ... since it has been a long time ... potentially larger differences. 

There's a build running that has all the other updates for prereqs I mentioned at PMC meeting (e.g. to Eclipse RC3) so I'd like that to finish normally ... 2 or 3 hours left ... but, after that, it'd be good to do a re-build with these udpates too. 

Once Tran checks in the changes (and, when the wtp 3.3 I build is no longer running) Tran will have to "manually" start the build ... as its purposely not triggered by releng changes.
Comment 3 Neil Hauge CLA 2011-06-01 16:19:49 EDT
PMC notification for this non-code change.  Tran will post a patch when it is ready and restart the build to incorporate the changes.
Comment 4 David Williams CLA 2011-06-01 16:38:42 EDT
I'm in favor of including this in a build. But, have you check the code against the new versions, in a PDE runtime target? Make sure JPA Diagram editor compiles? No versioning issues? 

Always a good question :) but, I'm also asking to figure out how to time the update and new build. Even though current build has been running for 7 hours, it is still on the "compile dali sdk" step ... in other words, even if it suddenly started going normal speed, it'd have around 4 hours left. 

So, if you are confident in the changes, I'd recommend we update the pre-req, and restart the build. Let me know if you'd like to do that ... otherwise, I'll let the current one limp along a little longer. We might have to kill it anyway ... with all the infrastructure problems and people hogging the signing queue :) not sure I'm trusting a build that takes so much longer than usual.
Comment 5 Neil Hauge CLA 2011-06-01 17:10:08 EDT
(In reply to comment #4)
> I'm in favor of including this in a build. But, have you check the code against
> the new versions, in a PDE runtime target? Make sure JPA Diagram editor
> compiles? No versioning issues? 

Yep...everything looks good.  Actually, I was surprised to find that the only difference between the 1.4 and 1.5 version is the features themselves.  The plugins inside are the same exact versions.

> 
> Always a good question :) but, I'm also asking to figure out how to time the
> update and new build. Even though current build has been running for 7 hours,
> it is still on the "compile dali sdk" step ... in other words, even if it
> suddenly started going normal speed, it'd have around 4 hours left. 

Yikes...now that is slow.

> 
> So, if you are confident in the changes, I'd recommend we update the pre-req,
> and restart the build. Let me know if you'd like to do that ... otherwise, I'll
> let the current one limp along a little longer. We might have to kill it anyway
> ... with all the infrastructure problems and people hogging the signing queue
> :) not sure I'm trusting a build that takes so much longer than usual.

Yep...I think we could probably restart, but I'll wait for Tran to vouch for his changes. : )
Comment 6 Tran Le CLA 2011-06-01 17:52:26 EDT
Created attachment 197182 [details]
Proposed patch

David, I have tested manually the runtime zip URL and I feel confident about the changes.
Please restart the build if it is appropriate.
Comment 7 David Williams CLA 2011-06-01 18:02:56 EDT
> Please restart the build if it is appropriate.

Ok, I will restart ... I noticed, though, that the compile part of build is (almost) over, so I'll let that part finish, but then cancel and restart, rather than wait for unit tests to run. 

thanks,
Comment 8 Tran Le CLA 2011-06-02 01:49:19 EDT
Looks like the build is still really slow. I think that compilation is not through yet!
Comment 9 Neil Hauge CLA 2011-08-25 14:11:51 EDT
I think this was resolved in RC4.