Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347949 - [server][git] Need API change to display more information on git-log view
Summary: [server][git] Need API change to display more information on git-log view
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 347911 349290 349291
  Show dependency tree
 
Reported: 2011-06-01 10:31 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-01 11:41 EDT (History)
3 users (show)

See Also:
malgorzata.tomczyk: review+
Szymon.Brandys: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-06-01 10:31:37 EDT
There is a difference in displaying log for remote and local branch in client.
For remote: we pass remote location and then we do GET to the remote location to get the CommitLocation
For local branch: we pass the CommitLocation directly 

For local branch we don't have to make a separate call to get the CommitLocation but we don't have access to branch details. The detailed information wasn't necessary until now, but if we want to fix bug 347911, we will have to have some extra details about the branch.

I see two possible resolutions of this problem
1. pass branch location to UI instead of commit location, but then we have to add DefaultBranchLocation to Git decoration in file API, because we also open git log from navigator.
2. add some extra information about branch on GET on CommitLocation

I like the 1. better because we would have the consistent approach to git log.
Comment 1 Szymon Brandys CLA 2011-06-14 04:29:48 EDT
Thanks Piotrek. This bug was about more data for local branches, so I'll release just this part. I'll raise a separate bug for adding details for remote tracking branches and tests.
Comment 2 Szymon Brandys CLA 2011-06-14 04:50:12 EDT
Fixed with 5ac145d321dc553474e65476a36e2ced173f2e4d.