Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347940 - [Compatibility] Timer execs greatly affect XWindow based systems
Summary: [Compatibility] Timer execs greatly affect XWindow based systems
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 4.1 RC4   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-01 09:38 EDT by Eric Moffatt CLA
Modified: 2011-06-06 09:49 EDT (History)
3 users (show)

See Also:
emoffatt: review?

Attachments
Gather up all the items to be checked rather than spawning a new timerExec for each one (4.89 KB, patch)
2011-06-01 11:14 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-06-01 09:38:28 EDT 
While Car was testing 4.1 on the various platforms she noticed that the performance was *very* bad (about 1 character per sec typing in an editor).

We tracked this down to the use of multiple timerExec's used to keep the various toolbars enablement state up to date...
Comment 1 Eric Moffatt CLA 2011-06-01 11:14:00 EDT 
Created attachment 197100 [details]
Gather up all the items to be checked rather than spawning a new timerExec for each one
Comment 2 Eric Moffatt CLA 2011-06-01 11:15:36 EDT 
Paul, please review the patch...
Comment 3 Paul Webster CLA 2011-06-01 12:02:22 EDT 
I've only made one slight change.  The HCI can create one instance of the safe runnable, instead of one per call, since it contains no state and doesn't change.

Committed to HEAD.  Remy, could you also have a quick look at what I've committed as a confirmation?


PW
Comment 4 Remy Suen CLA 2011-06-01 12:30:46 EDT 
(In reply to comment #3)
> Committed to HEAD.  Remy, could you also have a quick look at what I've
> committed as a confirmation?

Looks okay to me.
Comment 5 Eric Moffatt CLA 2011-06-01 13:53:20 EDT 
Marking as FIXED.
Comment 6 Eric Moffatt CLA 2011-06-06 09:49:48 EDT 
Verified in I20110604-2201.