Community
Participate
Working Groups
Hello, I've created a unit test that check: - the existence of the tag "(Incubation)" in the bundle name; - the bundle version; - the bundle provider; - the existence of an about.html file. Some bundles are not conform. Here is the list: Wrong Bundle-Name in: org.eclipse.emf.facet.util.core -> Bundle-Name Wrong Bundle-Vendor in: org.eclipse.emf.facet.infra.query.tests -> Mia Software org.eclipse.emf.facet.tests.util.swtbot -> Eclipse Modeling Platform org.eclipse.emf.facet.util.core -> Bundle-Vendor org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample -> Eclipse Modeling Platform Wrong Bundle-Version in: org.eclipse.emf.facet.capabilities -> 0.9.0.qualifier org.eclipse.emf.facet.efacet.core -> 0.2.0.qualifier org.eclipse.emf.facet.efacet.tests -> 0.0.1.qualifier org.eclipse.emf.facet.tests -> 0.9.0.qualifier org.eclipse.emf.facet.tests.util.swtbot -> 0.0.1.qualifier org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample -> 0.0.1.qualifier org.eclipse.emf.facet.widgets.nattable.tests -> 0.0.1.qualifier org.eclipse.emf.facet.widgets.nattable.tests.bug344563 -> 0.0.1.qualifier About files are missing in: org.eclipse.emf.facet.widgets.nattable.tests.bug344563 Regards, Gregoire Dupe
Created attachment 197089 [details] Unit test to check that the plug-ins conform to the release train rules Here is a unit test to check that the plug-ins conform to the release train rules. (a) I, Gregoire Dupe, wrote 100% of the code. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features.
Created attachment 197091 [details] Patch to fix non conform bundles Hello Ed, Kenn, Nicolas and Hugo, Here is a patch to fix this bug. (a) I, Gregoire Dupe, wrote 100% of the code. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. The patch modifies the following test plug-ins (not delivered in Indigo repository): - org.eclipse.emf.facet.widgets.nattable.tests.bug344563 - org.eclipse.emf.facet.efacet.tests - org.eclipse.emf.facet.tests - org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample - org.eclipse.emf.facet.widgets.nattable.tests - org.eclipse.emf.facet.infra.query.tests - org.eclipse.emf.facet.tests.util.swtbot This patch modifies the following "example" plug-ins (not delivered in Indigo repository, only in SVN): - org.eclipse.emf.facet.capabilities This patch modifies the following "public" plug-ins (delivered in Indigo repository): - org.eclipse.emf.facet.util.core (the version number is not modified) To my mind this patch has to be committed before RC4. Do you agree to commit the fix and the unit test class? Regards, Gregoire Dupe
I add Vincent Lorenzo and Patrick Tessier (which are Papyrus committers) in the CC list to inform them about this changes in EMF Facet.
+1 according to the modifications mentioned in Comment #2 Just one question: according to Description, org.eclipse.emf.facet.efacet.core qualifier should also be modified, should the patch be upgraded accordingly? Regards, Hugo (In reply to comment #2) > Created attachment 197091 [details] > Patch to fix non conform bundles > > Hello Ed, Kenn, Nicolas and Hugo, > > Here is a patch to fix this bug. > > (a) I, Gregoire Dupe, wrote 100% of the code. > (b) I have the right to contribute the code to Eclipse. > (c) I contribute the content under the EPL. > (d) This contribution contains no Cryptography features. > > The patch modifies the following test plug-ins (not delivered in Indigo > repository): > - org.eclipse.emf.facet.widgets.nattable.tests.bug344563 > - org.eclipse.emf.facet.efacet.tests > - org.eclipse.emf.facet.tests > - org.eclipse.emf.facet.widgets.celleditors.ecore.tests.samplemm.sample > - org.eclipse.emf.facet.widgets.nattable.tests > - org.eclipse.emf.facet.infra.query.tests > - org.eclipse.emf.facet.tests.util.swtbot > > This patch modifies the following "example" plug-ins (not delivered in Indigo > repository, only in SVN): > - org.eclipse.emf.facet.capabilities > > This patch modifies the following "public" plug-ins (delivered in Indigo > repository): > - org.eclipse.emf.facet.util.core (the version number is not modified) > > To my mind this patch has to be committed before RC4. > > Do you agree to commit the fix and the unit test class? > > Regards, > Gregoire Dupe
(In reply to comment #4) > +1 according to the modifications mentioned in Comment #2 > > Just one question: according to Description, org.eclipse.emf.facet.efacet.core > qualifier should also be modified, should the patch be upgraded accordingly? I've havn't added this modification in the patch because this is covered by this bug 347900. I've a good news: there is no need to modify org.eclipse.emf.facet.util.core. ( There was some thing wrong with SVN in my workspace. I wont commit the part of the patch modifying the plug-in org.eclipse.emf.facet.util.core. There is then no impact on the plug-ins delivered in Indigo repositories. Regards, Gregoire Dupe
Something wrong happened with the review flags. I've received the following e-mails: Kenn Hussey <Kenn.Hussey@gmail.com> has granted Gregoire Dupe <gdupe@mia-software.com>'s request for pmc_approved: Bug 347924: Bundles not conform to the Eclipse release train rules https://bugs.eclipse.org/bugs/show_bug.cgi?id=347924 Ed Merks <Ed.Merks@gmail.com> has granted Gregoire Dupe <gdupe@mia-software.com>'s request for pmc_approved: Bug 347924: Bundles not conform to the Eclipse release train rules https://bugs.eclipse.org/bugs/show_bug.cgi?id=347924 Hugo Bruneliere <hugo.bruneliere@inria.fr> has granted Gregoire Dupe <gdupe@mia-software.com>'s request for review: Bug 347924: Bundles not conform to the Eclipse release train rules https://bugs.eclipse.org/bugs/show_bug.cgi?id=347924 Nicolas Bros <nbros@mia-software.com> has granted Gregoire Dupe <gdupe@mia-software.com>'s request for review: Bug 347924: Bundles not conform to the Eclipse release train rules https://bugs.eclipse.org/bugs/show_bug.cgi?id=347924 I suppose, I can commit those patches.
Comment on attachment 197089 [details] Unit test to check that the plug-ins conform to the release train rules I've committed this patch. Committed revision 709.
Comment on attachment 197091 [details] Patch to fix non conform bundles I've committed this patch. Committed revision 709.
Something is definitely wrong with Bugzilla. That's the third time I add the same review+
The bug can be marked as fixed.
Hello, I’ve check the version of the EMF Fact plug-ins by installing EMF Facet from releases/indigo/stagingRC4. The bundle unit test succeed in the last integration build: https://hudson.eclipse.org/hudson/job/emffacet-integration/lastCompletedBuild/testReport/org.eclipse.emf.facet.tests.AllTests$org.eclipse.emf.facet.tests/BundleTest/ The bundle unit test succeed in the last nightly build: https://hudson.eclipse.org/hudson/job/emffacet-nightly/lastCompletedBuild/testReport/org.eclipse.emf.facet.tests.AllTests$org.eclipse.emf.facet.tests/BundleTest/ This bug can be closed. Regards, Gregoire
