Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347856 - ResetCommand with path doesn't reset a file
Summary: ResetCommand with path doesn't reset a file
Status: RESOLVED DUPLICATE of bug 348524
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 347855 (view as bug list)
Depends on:
Blocks: 347776
  Show dependency tree
 
Reported: 2011-05-31 15:35 EDT by Tomasz Zarna CLA
Modified: 2011-07-13 06:52 EDT (History)
3 users (show)

See Also:

Attachments
failing test case (920 bytes, text/plain)
2011-05-31 15:35 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-05-31 15:35:37 EDT 
Created attachment 197035 [details]
failing test case

In Orion, we started to use ResetCommand to unstage individual files. It works for most cases, but there are cases when it doesn't work as expected. For some reason, in those cases a selected file is not reset and stays modified and changed (MM) at the same time.

I've prepared a quick test that clones a tiny repository from github, modifies a file in it, stage it and then tries to unstage the file.

If you agree there is something wrong going on there I'm eager to prepare a better test. I didn't want to spend to much time on it, because maybe I'm missing something obvious.
Comment 1 Tomasz Zarna CLA 2011-05-31 15:37:13 EDT 
*** Bug 347855 has been marked as a duplicate of this bug. ***
Comment 2 Tomasz Zarna CLA 2011-07-11 07:32:46 EDT 
Would anyone take a look at the test and an eventual fix if I provided them? I'm asking because it wasn't enough to bring your attention to bug 349848 (http://egit.eclipse.org/r/3756) and bug 348524 (http://egit.eclipse.org/r/3666).
Comment 3 Tomasz Zarna CLA 2011-07-13 06:52:06 EDT 
The provided test case passes when run against JGit with fix from http://egit.eclipse.org/r/#change,3713. Marking as a dupe of bug 348524 for which the change has been created.

*** This bug has been marked as a duplicate of bug 348524 ***