Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347797 - [Theming][Menu] Enhance MenuItem theming
Summary: [Theming][Menu] Enhance MenuItem theming
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5 M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-31 10:39 EDT by Holger Staudacher CLA
Modified: 2011-12-08 06:28 EST (History)
4 users (show)

See Also:


Attachments
increased MenuItem padding and separator padding (2.61 KB, patch)
2011-12-06 05:56 EST, Nick Mussin CLA
ivan: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-05-31 10:39:22 EDT
Currently, if you want to theme a menu you can influence the menu's size by setting a padding on the Menu. But this has an ugly side effect.

To see what I mean set the padding to e.g. 15px. Then you need to hover a menu item (it need to change it's background on hover). You will see that the padding does not change it's background. This is the expected behaviour.

But currently we don't provide any possibility to affect the menu item's size. We do not allow setting a padding, margin or something else. This makes it's nearly impossible to style menu well. AS a result we can affect the size of a menu via theming, but we can't affect the size of a meu item via theming.
Comment 1 Tim Buschtoens CLA 2011-06-01 06:01:42 EDT
So, if i understand this correctly, we should make padding for MenuItem themeable? Margin would also be possible, but the hover effect would still not extend to the margin, as the margin is not part of the item.
Comment 2 Nick Mussin CLA 2011-12-06 05:56:47 EST
Created attachment 207965 [details]
increased MenuItem padding and separator padding
Comment 3 Nick Mussin CLA 2011-12-06 05:57:58 EST
MenuItem now has a padding property.
Comment 4 Nick Mussin CLA 2011-12-06 05:59:28 EST
Please make the Menu-Separator-Line themable. Currently it's margin and padding properties are hard-coded in Menu.appearance.js
Comment 5 Nick Mussin CLA 2011-12-06 06:01:15 EST
Sorry, I was talking of "menu-separator" not "menu-separator-line"
Comment 6 Ivan Furnadjiev CLA 2011-12-08 06:27:40 EST
Applied patch to CVS HEAD and made Menu[SEPARATOR] "padding" property themable.