347742 – XWT locks on initialization with GTK

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347742 - XWT locks on initialization with GTK

Summary: XWT locks on initialization with GTK

Status:	RESOLVED FIXED

Alias:	None

Product:	XWT
Classification:	Technology
Component:	Core (show other bugs)
Version:	unspecified
Hardware:	PC Linux-GTK

Importance:	P3 normal (vote)
Target Milestone:	0.10.0 RC
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-31 03:56 EDT by Mathieu Velten
Modified:	2013-12-12 10:17 EST (History)
CC List:	2 users (show)

See Also:

Attachments
fix v1 (683 bytes, patch) 2011-05-31 03:57 EDT, Mathieu Velten	yves.yang: iplog+	Details \| Diff
fix v2 (798 bytes, patch) 2013-06-17 07:07 EDT, Nikita Tikhomirov	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Velten

2011-05-31 03:56:41 EDT

when XWT loads on linux GTK it fully blocks the eclipse UI, in the checkInitialization method.

after investigating it is because checkInitialization needs the initializers to be initialized, which is done in runInitializers. It is only called from XWTLoaderManager.getDefault, so I deduced that XWTLoaderManager.getDefault should be called before checkInitialization in runOnUIThread and it is not the case for gtk an cocoa.

You can find a patch attached that fix it, but I am not sure it is correct since I don't fully understand the code.

Comment 1 Mathieu Velten

2011-05-31 03:57:07 EDT

Created attachment 196965 [details]
fix v1

Comment 2 Yves YANG

2011-05-31 08:21:14 EDT

Thanks. I'll take care of the integration.

Comment 3 Yves YANG

2011-06-03 03:18:14 EDT

committed in Head -> 20110603

Comment 4 Mathieu Velten

2011-06-06 05:50:23 EDT

Thanks !

Comment 5 Nikita Tikhomirov

2013-06-17 06:46:28 EDT

On source migration this line had disappeared again, I believe the same thing should be now fixed for org.eclipse.xwt.

Comment 6 Nikita Tikhomirov

2013-06-17 07:07:35 EDT

Created attachment 232428 [details]
fix v2

Comment 7 Nikita Tikhomirov

2013-06-17 07:18:08 EDT

BTW, is there any reason why that block of code special for gtk should exist?

Comment 8 Yves YANG

2013-12-12 05:05:09 EST

The fix v2 is applied. Sorry for this error.