Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347703 - CVS changes not reflected in prepare changelog output (first time)
Summary: CVS changes not reflected in prepare changelog output (first time)
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: ChangeLog (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Jeff Johnston CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-30 16:53 EDT by Andrew Overholt CLA
Modified: 2011-08-31 16:13 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2011-05-30 16:53:26 EDT
The first time I use Project->Prepare ChangeLog or Ctrl-Alt-p for a CVS project, it failed to create a ChangeLog file.  If I first did Ctrl-Alt-c from a file in my checkout, let it create a ChangeLog file, *then* pressed Ctrl-Alt-p, it worked.  I was using this CVS server:

 dev.eclipse.org
  cvsroot/org.eclipse
  myuserid
  ext

  www/linuxtools
  
I made a change to 2 index.php files, pressed F5 to make Eclipse refresh, watched it run through all the files in the CVS project to verify their "refresh" state and then nothing happened.  When I manually created ChangeLog and left it open, things worked as expected for the locally-altered files.
Comment 1 Andrew Overholt CLA 2011-06-03 15:35:06 EDT
I can't reproduce this with our latest build available now at:

http://download.eclipse.org/technology/linuxtools/updates-nightly/

org.eclipse.linuxtools.changelog.core_2.7.0.201106031355.jar
org.eclipse.linuxtools.changelog.cparser_2.7.0.201106031355.jar
org.eclipse.linuxtools.changelog.doc_2.7.0.201106031355.jar
org.eclipse.linuxtools.changelog.parsers.java_2.7.0.201106031355.jar

Closing.
Comment 2 Andrew Overholt CLA 2011-06-03 15:35:39 EDT
Closing for real.
Comment 3 Andrew Overholt CLA 2011-06-06 13:22:26 EDT
I can reproduce this again.  Post-Indigo.
Comment 4 Andrew Overholt CLA 2011-08-19 15:11:52 EDT
Do you think we can fix this for 0.8.1, Jeff? Or should it wait for 0.9.0 at the earliest?
Comment 5 Jeff Johnston CLA 2011-08-22 18:15:38 EDT
(In reply to comment #4)
> Do you think we can fix this for 0.8.1, Jeff? Or should it wait for 0.9.0 at
> the earliest?

I should have paid more attention to you reopening this.

The CTRL-ALT-P was changed to not create a ChangeLog if one does not exist.  The docs do not reflect this.

This was due to the problem of different ChangeLog formats and trying to default the creation of a ChangeLog (rather than bring up a dialog) when the files are located in the top-level directory.  Some ChangeLogs can be designated infile (e.g. rpm files whereby the ChangeLog is in the file itself).
Hitting CTRL+ALT+P for the whole project resulted in a problem in determining whether a ChangeLog file should be created or whether the infile ChangeLog is always to be used (e.g. rpm project).  The result was to not create the ChangeLog if it was missing since CTRL+ALT+P would do the wrong thing for an rpm project.

If you ask to create a ChangeLog entry in a file via CTRL+ALT+C, then you are manually asking for the entry for that file and you are essentially getting what you ask for.

If this behaviour is unacceptable, I'm open to what you think would be the best approach in the mixed case (rpm project).
Comment 6 Andrew Overholt CLA 2011-08-23 10:45:25 EDT
I think asking for the location is more appropriate than doing nothing.  This will work for the mixed case, too, but will require a different dialogue (ex. something asking for a location OR an in-place log).
Comment 7 Jeff Johnston CLA 2011-08-31 16:13:46 EDT
(In reply to comment #6)
> I think asking for the location is more appropriate than doing nothing.  This
> will work for the mixed case, too, but will require a different dialogue (ex.
> something asking for a location OR an in-place log).

Ok, a fix has been committed into master.  The behaviour is now that Prepare ChangeLog will ask the user for the ChangeLog location if a ChangeLog is not found.  If the user cancels that dialog (e.g. in the case of an rpm project), no ChangeLog will be created and the user will not be asked again for that action.  A subsequent Prepare ChangeLog will do the same thing again and ask first and then don't ask again for the remainder of the action.