Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347627 - [server] GitUtils#getGitDir should accept depth parameter
Summary: [server] GitUtils#getGitDir should accept depth parameter
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 347766
  Show dependency tree
 
Reported: 2011-05-30 07:02 EDT by Tomasz Zarna CLA
Modified: 2011-09-01 11:42 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-05-30 07:02:53 EDT
In some cases[1] we don't want GitUtils#getGitDir[2] to scan parents of the given path. Currently there is no way to achieve this. Also, GitUtils#getGitDirs[3] which looks for git repositories in children of the given path could benefit from a parameter that would specify how far to recurse.

[1] eg in org.eclipse.orion.server.git.servlets.GitCloneHandlerV1.handlePut(HttpServletRequest, HttpServletResponse, String)
[2] org.eclipse.orion.server.git.servlets.GitUtils.getGitDir(IPath)
[3] org.eclipse.orion.server.git.servlets.GitUtils.getGitDirs(IPath, Map<IPath, File>)
Comment 1 Tomasz Zarna CLA 2011-06-01 07:13:56 EDT
If the new method returned not only File with the repo but also an IPath (under /file) that would be handy for fixing bug 347766.