Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347594 - dash signing plugin creates an osgi.bundle packed artifact when the IU is in fact a bundle
Summary: dash signing plugin creates an osgi.bundle packed artifact when the IU is in ...
Status: CLOSED FIXED
Alias: None
Product: Dash
Classification: Technology
Component: Maven (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Jesse McConnell CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-29 23:47 EDT by Hugues Malphettes CLA
Modified: 2011-08-01 12:50 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugues Malphettes CLA 2011-05-29 23:47:19 EDT 
When building the jetty-rt-products the artifacts.xml contain one mistake:
The packed IU:
   <artifact classifier="osgi.bundle" id="org.eclipse.jetty.slf4jlogback.source" version="7.4.2.201105282013">

is in fact a feature:
   <artifact classifier="org.eclipse.update.feature" id="org.eclipse.jetty.slf4jlogback.source" version="7.4.2.201105282013">

I have reproduced this issue consistently.


jetty-rt-products:
------------------
svn co
http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-rt-indigo/

The pom.xml file that uses the signing plugin:
http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-rt-indigo/jetty-features/org.eclipse.jetty.product/pom.xml

The hudson job:
https://hudson.eclipse.org/hudson/view/Jetty-RT/job/jetty-rt-products/
Comment 1 David Carver CLA 2011-05-30 10:30:08 EDT 
Hughs try the latest version 1.0.1, it might be addressed with some changes that were done with the md5Checksum fixes.

The alternative is to not name a bundle and feature with the same name.
Comment 2 Hugues Malphettes CLA 2011-05-30 22:11:47 EDT 
As discussed on the chat: there is no bundle called org.eclipse.jetty.slf4jlogback.source

I think the bug is here:
http://git.eclipse.org/c/dash/org.eclipse.dash.maven.git/tree/eclipse-maven-signing-plugin/src/main/java/org/eclipse/dash/m4e/eclipse/signing/ChecksumMojo.java#n248

The line:
  packed.setAttribute("classifier","osgi.bundle");
should be:
  packed.setAttribute("classifier", isPlugin ? "osgi.bundle" : "org.eclipse.update.feature");
Comment 3 Hugues Malphettes CLA 2011-06-01 06:23:39 EDT 
Bug 347591's latest patch contains the fix for this issue.
Comment 4 Jesse McConnell CLA 2011-08-01 12:50:33 EDT 
fixed with Bug 347591 applied patch