Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347587 - [package explorer] Empty parent packages are not filtered correctly if they contain .svn folder
Summary: [package explorer] Empty parent packages are not filtered correctly if they c...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-29 15:37 EDT by arthur3262 CLA
Modified: 2012-03-30 06:34 EDT (History)
3 users (show)

See Also:

Attachments
Fix (2.17 KB, patch)
2011-05-30 06:42 EDT, Markus Keller CLA 		no flags Details | Diff
Fix 2 (988 bytes, patch)
2011-05-30 06:45 EDT, Markus Keller CLA 		no flags Details | Diff
Fix 3 (1.86 KB, patch)
2011-05-30 09:51 EDT, Markus Keller CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arthur3262 CLA 2011-05-29 15:37:44 EDT 
Build Identifier: 20110218-0911

org
 |
 `-.svn (filtered)
org.test
 |
 `-.svn (filtered)

The filter "Empty parent packages" does not hide a parent package if it contains filtered .svn ressource folders. So logically they are empty but the filter does not think that.

Reproducible: Always

Steps to Reproduce:
1. Check out a project from svn in Windows 7 with TortoriseSVN
2. Import the project in eclipse (without using subclipse or subversive etc.)
3. Enable the .ressources and empty parent packages filters
Comment 1 Dani Megert CLA 2011-05-30 03:19:34 EDT 

*** This bug has been marked as a duplicate of bug 22202 ***
Comment 2 Markus Keller CLA 2011-05-30 06:41:27 EDT 
Unlike bug 22202, this bug is about empty parent packages, not about empty folders or source folders.

We should fix this the same way as bug 242069.
Comment 3 Markus Keller CLA 2011-05-30 06:42:03 EDT 
Created attachment 196876 [details]
Fix
Comment 4 Markus Keller CLA 2011-05-30 06:45:31 EDT 
Created attachment 196877 [details]
Fix 2

Better fix that avoids code duplication.
Comment 5 Markus Keller CLA 2011-05-30 09:51:57 EDT 
Created attachment 196893 [details]
Fix 3

Fix 2 was incomplete due to bug 347652.