Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347522 - [UI] Add new Filter: Hide Completed Reviews
Summary: [UI] Add new Filter: Hide Completed Reviews
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.9   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 17:04 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-01-17 22:49 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-05-27 17:04:08 EDT
As the number of reviews increases, it is necessary to hide the ones no longer relevant.
For example the combination of the following two filters shall be the preference for the majority of the users:

 * Show my Reviews
 * Hide completed reviews
 
 The above will show the active reviews where a participant is involved.
And if the user wants to see only the active ones that he has not marked reviewed he can further refine it with
* Hide Reviewed elements

The three filters above will display the user's backlog which can actually be triggered by a single action which can active these three filters.
Comment 1 Sebastien Dubois CLA 2011-06-28 17:50:06 EDT
The problem here is that we need to open a review to see if it is completed.  Since only the current review is open at any given time, it is not trivial to do this.
Comment 2 Sebastien Dubois CLA 2011-06-29 12:06:06 EDT
A possible solution to this would be to maintain a list of completed reviews at the Review Group level.  At R4E startup we can open all review groups and cache that list in the UI model, so that it is available at filtering time.  We will need to update that list every time a review is completed.  This will require changes in the UI and core component.
Comment 3 Sebastien Dubois CLA 2011-09-06 16:32:37 EDT
Functionality implemented
Comment 4 Alvaro Sanchez-Leon CLA 2011-09-06 17:06:32 EDT
There are multiple options in the description and comments above, 
please document what was implemented, 

Any pending items ?
Comment 5 Sebastien Dubois CLA 2011-09-06 17:11:51 EDT
(In reply to comment #4)
> There are multiple options in the description and comments above, 
> please document what was implemented, 
> 
> Any pending items ?

The hide completed reviews filter is implemented, including default filter settings.  As for the combination of filters, this is the user's responsibility.

What we can do eventually is to provide the preferences values we think should be implemented by default as a separate .properties files.  This is lower priority and can be handled as a separate bug.  We also have to see since we have other bugs to remove preferences values as per Mylyn guidelines