Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347454 - Usability problems with the Sharing Wizard
Summary: Usability problems with the Sharing Wizard
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 356953
Blocks:
  Show dependency tree
 
Reported: 2011-05-27 09:53 EDT by Robin Rosenberg CLA
Modified: 2013-09-29 11:10 EDT (History)
3 users (show)

See Also:


Attachments
Illustration of the issue with four repos in the workspace (269.69 KB, image/png)
2011-05-27 10:32 EDT, Robin Rosenberg CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg CLA 2011-05-27 09:53:49 EDT
The Git sharing wizard used to figure out what project belongs to which repository. It no longer does that the user has to figure this out wihout any help
from the wizard. This is tedious and error prone with only a few projects.
Comment 1 Robin Rosenberg CLA 2011-05-27 09:56:07 EDT
Revert proposed as http://egit.eclipse.org/r/3552
Comment 2 Robin Rosenberg CLA 2011-05-27 10:32:12 EDT
Created attachment 196766 [details]
Illustration of the issue with four repos in the workspace
Comment 3 Mathias Kinzler CLA 2011-05-31 02:18:28 EDT
The previous behavior is still available by checking the "Create or use Repository in parent folder of project", isn't it?
Comment 4 Robin Rosenberg CLA 2011-05-31 17:41:58 EDT
(In reply to comment #3)
> The previous behavior is still available by checking the "Create or use
> Repository in parent folder of project", isn't it?

Yea, but it's very confusing to get confronted with a view that so
desperately seeks mess with my repos. It should not suggest to move
projects that are already located inside repos. Those projects should
at least be unchecked in the new pane.

Maybe it would be easier to understand if that was a tabbed
dialog since it very much behaves like one.

Also drop the message about it being discourages to have repos in the
workspace. I¨m not sure what the problem is. I know there was a discussion,
and some people don't like it, but then people like different styles and
that doesn't mean one is bad and the other isn't.
Comment 5 Robin Rosenberg CLA 2011-05-31 18:23:43 EDT
....
Actually I see a place for the warning. 

1. Trying to create a repo at the workspace level. That'd bad

2. Creating a a repo directly below in project that is directly below
the workspace. That is not necessarily, but is often the result of not
thinking about the repository layout. One does not usually want that. 
On the other hand making that error in the "git" workspace isn't any better.

But the warning should ONLY be given when attempting to CREATE a new repo.
Comment 6 Mathias Kinzler CLA 2011-06-01 11:31:37 EDT
Fix proposed at http://egit.eclipse.org/r/#change,3616
Comment 7 Matthias Sohn CLA 2011-06-01 11:53:51 EDT
merged Mathias' fix as 547708a4718b9f639a7eaa57d88ae30ff4b8935c

Can we close this bug or do you see more things we should improve here ?
Comment 8 Robin Rosenberg CLA 2011-06-01 17:20:40 EDT
(In reply to comment #7)
> merged Mathias' fix as 547708a4718b9f639a7eaa57d88ae30ff4b8935c
> 
> Can we close this bug or do you see more things we should improve here ?

Make it much arder for the user to do the wrong thing and not default to
it. The warning was the minor issue here. I listed the major issue first.
Comment 9 Robin Rosenberg CLA 2011-06-01 19:00:05 EDT
Posted a minimal patch to gerrit.
Comment 10 Robin Stocker CLA 2013-09-29 11:10:49 EDT
(In reply to Robin Rosenberg from comment #9)
> Posted a minimal patch to gerrit.

This was merged it seems as 5f8010c46bda0af8cca4fd452f8654f486aee52a, closing this as fixed.