Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347446 - Get rid of the test suites
Summary: Get rid of the test suites
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Rüdiger Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 347573
Blocks:
  Show dependency tree
 
Reported: 2011-05-27 09:33 EDT by Rüdiger Herrmann CLA
Modified: 2011-06-03 04:49 EDT (History)
0 users

See Also:

Attachments
RWTAllTestSuite that returns all classes on the class path that match *_Test (4.96 KB, patch)
2011-05-29 12:50 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
Proposed fix (36.03 KB, patch)
2011-06-03 04:47 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-05-27 09:33:26 EDT 
Maintaining the test suites (RWTHostTestSuite, RWTQ07TestSuite, etc.) is tedious and error prone. They should be replaced by a simple means (e.g. a launch configuration) that runs all the tests that are currently referenced from the various test suites.
Comment 1 Rüdiger Herrmann CLA 2011-05-29 12:50:05 EDT 
Created attachment 196853 [details]
RWTAllTestSuite that returns all classes on the class path that match *_Test

This patch replaces the manual listing of test suites in RWTAllTestSuite with code that scans the class path for classes that match*_Test and adds those classes to the gtest suite.
With these changes, the number of tests increeased from 2615 to 2639. At first glance, it looks like the existing tests suite misses some tests, but this needs further investiagtion.
Comment 2 Rüdiger Herrmann CLA 2011-05-30 06:42:35 EDT 
Several test classes are missing from the test suites (e.g. KeyEvent_Test, NumberFormatUtil_Test, QxShadow_Test, ...). After adding these tests to the respective test suites, the number of tests are the same with both the 'manual' and the 'classpath' test suite.
Changes are in CVS HEAD.
Comment 3 Rüdiger Herrmann CLA 2011-05-30 09:58:05 EDT 
On the build server, 2.657 tests are executed in total (18 more than RWTAllTestSuite). This is because the tests from org.eclipse.rap.ui.forms.test are also executed.
We should consider to integrate these tests into the RWTAllTestSuite.
Comment 4 Rüdiger Herrmann CLA 2011-05-31 12:19:03 EDT 
We should consider to also include org.eclipse.rwt.widgets.styledtext.test (another 10 or so tests)
Comment 5 Rüdiger Herrmann CLA 2011-06-03 04:47:28 EDT 
Created attachment 197293 [details]
Proposed fix

This patch replaces the current RWTAllTestSuite with the same implementation from patch #1 that dynamically scans the class path for *_Test classes.
In addition, all manual test suites were deleted (e.g. RWTQ07TestSuite, RWTHostTestSuite, ...). To run the same tests that are run on the build server, the tests from org.eclipse.rap.ui.forms.test and org.eclipse.rwt.widgets.styledtext.test have been included.
For now, the mixed dependency declaration in org.eclipse.rwt.test.all was kept. The dependency to JUnit is expressed as a bundle-dependency, whereas dependencies to the test projects are plain JDT classpath entries.
Comment 6 Rüdiger Herrmann CLA 2011-06-03 04:49:44 EDT 
Applied patch from attachment 197293 [details] to CVS HEAD.