Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347409 - SD builder does not merge or overwrite code
Summary: SD builder does not merge or overwrite code
Status: CLOSED FIXED
Alias: None
Product: AMP
Classification: Modeling
Component: General (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Urs Frei CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 04:31 EDT by Jonas Ruttimann CLA
Modified: 2011-06-07 08:59 EDT (History)
1 user (show)

See Also:

Attachments
FacadeHelper changed (6.23 KB, patch)
2011-05-27 08:09 EDT, Urs Frei CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Ruttimann CLA 2011-05-27 04:31:21 EDT 
The SD builder is supposed to overwrite code that has already been generated. The recently introduced annotation "@generated NOT" marks methods as manually changed. Therefore, the SD builder should not overwrite those methods.

However, it seems that the SD builder does not overwrite any code at all. That is a bug.
Comment 1 Urs Frei CLA 2011-05-27 08:09:23 EDT 
Created attachment 196748 [details]
FacadeHelper changed

What do you think about that? Jonas
Comment 2 Miles Parker CLA 2011-05-27 12:36:49 EDT 
Does this work for the other targets as well? Would be extremely cool if it did.
Comment 3 Jonas Ruttimann CLA 2011-05-30 01:42:52 EDT 
The merging technology is abviously not limited to SD plugins. Any builder could be extended to support @generated-tags and call the merger.

(In reply to comment #2)
> Does this work for the other targets as well? Would be extremely cool if it
> did.
Comment 4 Miles Parker CLA 2011-05-31 14:31:00 EDT 
(In reply to comment #3)
> The merging technology is abviously not limited to SD plugins. Any builder
> could be extended to support @generated-tags and call the merger.
> 
> (In reply to comment #2)
> > Does this work for the other targets as well? Would be extremely cool if it
> > did.

Looks good to me. :) What I was hinting at was whether you guys would be willing to set the same thing up for the rest of the gen projects?
Comment 5 Jonas Ruttimann CLA 2011-06-07 08:59:53 EDT 
Committed bug fix.

Right now, there's just not enough time to add code merging to all builders. But I'm sure it's not a great task to accomplish.