Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347379 - Manifest editor Add... imported package thows NPE
Summary: Manifest editor Add... imported package thows NPE
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.2   Edit
Hardware: PC Windows 7
: P3 major with 1 vote (vote)
Target Milestone: 3.6.2+   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 17:19 EDT by Troy Bishop CLA
Modified: 2011-05-27 13:04 EDT (History)
4 users (show)

See Also:
Michael_Rennie: review+

Attachments
Fix (reverse patch) (1.26 KB, patch)
2011-05-27 10:51 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2011-05-26 17:19:13 EDT 
Build Identifier: 

An NPE is thrown when you click Add... to add an imported package the
the manifest editor if that bundle has an export package with no version.

!ENTRY org.eclipse.ui 4 0 2011-05-26 16:47:17.882
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
	at org.eclipse.pde.internal.ui.editor.plugin.ImportPackageSection.setElements(ImportPackageSection.java:512)
	at org.eclipse.pde.internal.ui.editor.plugin.ImportPackageSection.access$3(ImportPackageSection.java:474)
	at org.eclipse.pde.internal.ui.editor.plugin.ImportPackageSection$3.run(ImportPackageSection.java:415)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.pde.internal.ui.editor.plugin.ImportPackageSection.handleAdd(ImportPackageSection.java:425)
	at org.eclipse.pde.internal.ui.editor.plugin.ImportPackageSection.buttonSelected(ImportPackageSection.java:344)
	at org.eclipse.pde.internal.ui.editor.TableSection$PartAdapter.buttonSelected(TableSection.java:50)
	at org.eclipse.pde.internal.ui.parts.SharedPartWithButtons$SelectionHandler.buttonSelected(SharedPartWithButtons.java:39)
	at org.eclipse.pde.internal.ui.parts.SharedPartWithButtons$SelectionHandler.widgetSelected(SharedPartWithButtons.java:30)
...

It looks like this was fixed in HEAD via bug 341575.  Can this fix be back ported to the 3.6 maintenance stream?

Reproducible: Always

Steps to Reproduce:
See bug 341575
Comment 1 Troy Bishop CLA 2011-05-26 17:22:00 EDT 
I marked this as 'major' because it is a regression from a previous 3.6.2 maintenance release due to the fix for bug 337909 introducing it.
Comment 2 Zina Mostafia CLA 2011-05-27 10:17:17 EDT 
Basically we need to port the fix for bug 41575 to 3.6.2
Comment 3 Zina Mostafia CLA 2011-05-27 10:18:54 EDT 
Sorry wrong in comment #2, we need the fix for bug 341575 to be ported to 3.6.2
Comment 4 Curtis Windatt CLA 2011-05-27 10:51:27 EDT 
Created attachment 196770 [details]
Fix (reverse patch)

Reverse patch taken from bug 341575.
Comment 5 Curtis Windatt CLA 2011-05-27 10:52:46 EDT 
Fix committed and released v20110527_r363.

Mike, please verify.
Comment 6 Michael Rennie CLA 2011-05-27 13:04:21 EDT 
+1 works as intended.