Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347365 - [UI] address UI review findings
Summary: [UI] address UI review findings
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 399526
  Show dependency tree
 
Reported: 2011-05-26 15:31 EDT by Alvaro Sanchez-Leon CLA
Modified: 2013-01-30 13:21 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-05-26 15:31:54 EDT
the following are some errors found during the UI review that need to be investigated:

Properties:
	- Review Level - Tab "All" - the list of properties is not complete
	- The path string is not shown, check it for file contexts and files
	- Formal Review: The class field was not editable
	
Dialogs:
	- The OK button seems enabled even if there is no valid input 

Design Rules:
    - The properties shall match the ones for the group, however one refers to the folder the other one to the file
Comment 1 Alvaro Sanchez-Leon CLA 2011-05-27 10:41:52 EDT
Adding one more:
Navigator: 
	- Editing the description of a comment does not refresh the label in the navigator but after closing and opening the review
Comment 2 Sebastien Dubois CLA 2011-06-10 16:24:43 EDT
Some answers

(In reply to comment #0)
> the following are some errors found during the UI review that need to be
> investigated:
> 
> Properties:
> - Review Level - Tab "All" - the list of properties is not complete
> - The path string is not shown, check it for file contexts and files
> - Formal Review: The class field was not editable

These are fixed

> 
> Design Rules:
> - The properties shall match the ones for the group, however one refers to
> the folder the other one to the file

To be consistent, the group should display the group file, not the folder
Comment 3 Sebastien Dubois CLA 2011-06-10 16:25:41 EDT
(In reply to comment #1)
> Adding one more:
> Navigator:
> - Editing the description of a comment does not refresh the label in the
> navigator but after closing and opening the review

Comments should not be editable once they are created
Comment 4 Sebastien Dubois CLA 2011-06-20 11:24:29 EDT
New additions after discusssing UI review internally among the team.  These are high-priority issues to be resolved before next release is out

- Remove "Link with Editor" function in Review Navigator.  The function should be commented out and refacter as a full sync later on.
- Make all properties R4E properties view->All property tab read-only for now
- Change R4E Properties view to have only 2 tabs:  List (old All) tab and Edit tab
- Use expandable composites in Edit tab to reduce footprint in view
- Remember folders when triggering ad folder dialogs
- New anomaly dialog:  Deisng rules should be shown in searchable table like in legacy R4E
- Add support to add reply to a Comment
- In formal reviews, prevent phase change when email is not sent out
- Disable mouse button scroll in all combo boxes
- Include icon legen in help
- When right-clicking in empty area of the review navigator, show default context-menu (not based on selected tree element)
- New review dialog: Do not put any default review type in combo box
-  All New xxx dialogs: do not enable OK button until minimal information is entered
- Always focus on newly created element in Review navigator tree
- Always display all options in send notification type dialog
- Fix scrollbars in R4E Properties view that are broken when resizing the view
- All text boxes should wrap in R4E porperties view
- Add command to configure the Groups/Rules sets from the review navigator (show appropriate properties)
- Remove Link with porperties command from review navigator (make it always enabled)


Lower priority tasks:
-Split review navigator view to show elements below the FileContext in separate table pane
-Save tree expansion state beofre using refresh command and restore it afterwards
Comment 5 Sebastien Dubois CLA 2011-06-28 18:14:36 EDT
	>> 
	>> Design Rules:
	>> - The properties shall match the ones for the group, however one refers to
	>> the folder the other one to the file

>To be consistent, the group should display the group file, not the folder

This is now inmplemented both REview Group and Rule Sets show the file path in their properties
Comment 6 Sebastien Dubois CLA 2011-07-25 17:40:44 EDT
Here's the current status on this item.

IMPLEMENTED for July release:

- Remove "Link with Editor" function in Review Navigator. The function should be commented out and refacter as a full sync later on.
- Make all properties R4E properties view->All property tab read-only for now
- New review dialog: Do not put any default review type in combo box
- Remove Link with porperties command from review navigator (make it always enabled)
- Always focus on newly created element in Review navigator tree
- Disable mouse button scroll in all combo boxes
- In formal reviews, prevent phase change when email is not sent out
- All New xxx dialogs: do not enable OK button until minimal information is entered


OUTSTANDING for July release:

- Change R4E Properties view to have only 2 tabs: List (old All) tab and Edit tab
- Use expandable composites in Edit tab to reduce footprint in view
- Include icon legen in help


OUTSTANDING as future improvements:

- Remember folders when triggering ad folder dialogs
- New anomaly dialog: Deisng rules should be shown in searchable table like in legacy R4E
- Add support to add reply to a Comment
- Always display all options in send notification type dialog
- Fix scrollbars in R4E Properties view that are broken when resizing the view
- All text boxes should wrap in R4E porperties view
- Add command to configure the Groups/Rules sets from the review navigator (show appropriate properties)


Potential future improvements:

-Split review navigator view to show elements below the FileContext in separate table pane
-Save tree expansion state beofre using refresh command and restore it afterwards


Will not be implemented
- When right-clicking in empty area of the review navigator, show default context-menu (not based on selected tree element).  
   --> This should not be implemented.  We now behave like any other navigator and changing the code will break that.
Comment 7 Sebastien Dubois CLA 2011-07-26 17:10:16 EDT
Update:

IMPLEMENTED for July release:

- Include icon legen in help
Comment 8 Sebastien Dubois CLA 2011-07-27 18:19:20 EDT
All outstanding issues for the July release are now done.

What's left:

OUTSTANDING as future improvements:

- Remember folders when triggering ad folder dialogs
- New anomaly dialog: Design rules should be shown in searchable table like in legacy R4E
- Add support to add reply to a Comment
- Always display all options in send notification type dialog
- Fix scrollbars in R4E Properties view that are broken when resizing the view
- All text boxes should wrap in R4E porperties view
- Add command to configure the Groups/Rules sets from the review navigator (show appropriate properties)

Potential future improvements:

-Split review navigator view to show elements below the FileContext in separate table pane
-Save tree expansion state beofre using refresh command and restore it afterwards
Comment 9 Alvaro Sanchez-Leon CLA 2012-04-18 20:04:35 EDT
Shall not be in Assigned state if assigned to default r4e-triaged
Comment 10 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn