Community
Participate
Working Groups
The new commit dialog doesn't follow the platform look&feel. All my other Eclipse dialogs have a great background, and the commit dialog is white. While it does look nice, the inconsistency is a show-stopper (IMHO). It reminds me of the saying "it's better to be consistently wrong than inconsistently right".
What do you propose? The dialog now uses the form toolkit and derives the background color from it. Are you suggesting to not use the form UI?
(In reply to comment #1) > What do you propose? The dialog now uses the form toolkit and derives the > background color from it. Are you suggesting to not use the form UI? Interesting. Is this really the first time that the form toolkit has been used inside a dialog? I did a quick look around the IDE and I don't see others. I just found that this dialog stood out like a sore thumb. Is the form toolkit really needed?
It definitely isn't need, it just presented what I thought was the best look and feel and offered a way to save vertical space by having toolbars in the section headers. You can see some of the other designs that were considered here: http://img.skitch.com/20110519-8ggj8ytsxtbmwbnmn92wbc2gf7.png http://img.skitch.com/20110519-dnecsyas3x1m4rb3aksuka1g1c.png http://img.skitch.com/20110519-mk2anb6ykahd2naj42euqwgefs.png
(In reply to comment #3) > It definitely isn't need, it just presented what I thought was the best look > and feel and offered a way to save vertical space by having toolbars in the > section headers. > > You can see some of the other designs that were considered here: > > http://img.skitch.com/20110519-8ggj8ytsxtbmwbnmn92wbc2gf7.png > http://img.skitch.com/20110519-dnecsyas3x1m4rb3aksuka1g1c.png > http://img.skitch.com/20110519-mk2anb6ykahd2naj42euqwgefs.png Yes, in the first two screen-shots, the one on the left works best.
The reason I opened this bug was because the colour scheme was not correct (*well not consistent). This turns out to be because it's using the Form Toolkit, and I haven't seen any other (platform) dialog use this. So, in fact it is consistent with all other dialogs that use the form toolkit. I've talked with others and they seem to like it (and FWIW, I like it too). Since the inconsistency is only really bothering me, and 'inconsistent' might not even be accurate, I'm going to close this bug as invalid. Keep up the good work Kevin!
