Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347313 - [client] Add UI to change Git repo configuration
Summary: [client] Add UI to change Git repo configuration
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on: 337820
Blocks: 348755
  Show dependency tree
 
Reported: 2011-05-26 09:15 EDT by Szymon Brandys CLA
Modified: 2011-09-01 09:52 EDT (History)
3 users (show)

See Also:
Szymon.Brandys: review+
malgorzata.tomczyk: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-05-26 09:15:08 EDT 
.
Comment 1 Szymon Brandys CLA 2011-06-07 13:26:18 EDT 
There is no triangle icon to close, open the details panel. Otherwise it looks good. Could you raise a separate bug for changing/adding/deleting variables?
Comment 2 Szymon Brandys CLA 2011-06-07 16:48:48 EDT 
(In reply to comment #1)
> There is no triangle icon to close, open the details panel. Otherwise it looks
> good. Could you raise a separate bug for changing/adding/deleting variables?

I forgot to add that the cursor should be changed when mouse is over the clone name, see the log view.
Comment 3 Szymon Brandys CLA 2011-06-07 17:11:44 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> > There is no triangle icon to close, open the details panel. Otherwise it looks
> > good. Could you raise a separate bug for changing/adding/deleting variables?
> 
> I forgot to add that the cursor should be changed when mouse is over the clone
> name, see the log view.

One more thing is: now when you click on the clone name, the details panel is opened. Before that it used to open the file navigator showing the folder with the repo. We need to add an action that provides that old behavior.
Comment 4 Piotr Janik CLA 2011-06-08 08:13:20 EDT 
Recent version was incomplete, now all things mentioned above are fixed.

https://github.com/pjanik/orion.client/tree/bug347313

it requires server with branch:
https://github.com/pjanik/orion.server/tree/bug337820

I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 5 Malgorzata Janczarska CLA 2011-06-08 09:27:49 EDT 
git-clones-explorer.js, lines 35-38. Why do you need getGitCloneConfigLocation function? You get it from clone.ConfigLocation.
Apart from this it looks good.
Comment 6 Piotr Janik CLA 2011-06-08 09:33:20 EDT 
(In reply to comment #5)
> git-clones-explorer.js, lines 35-38. Why do you need getGitCloneConfigLocation
> function? You get it from clone.ConfigLocation.
> Apart from this it looks good.

You're right. I've created this function, but later added ConfigLocation to clone object. Fixed, new version is without these lines.
Comment 7 Malgorzata Janczarska CLA 2011-06-08 10:10:47 EDT 
(In reply to comment #6)
> You're right. I've created this function, but later added ConfigLocation to
> clone object. Fixed, new version is without these lines.
Now it's OK.
Comment 8 Szymon Brandys CLA 2011-06-08 10:18:28 EDT 
(In reply to comment #7)
> (In reply to comment #6)
> > You're right. I've created this function, but later added ConfigLocation to
> > clone object. Fixed, new version is without these lines.
> Now it's OK.

I would change "Show content" to "Show in File Navigator" or simpler "Show in Navigator".
Comment 9 Piotr Janik CLA 2011-06-08 10:25:33 EDT 
> I would change "Show content" to "Show in File Navigator" or simpler "Show in
> Navigator".
Done.
Comment 10 Szymon Brandys CLA 2011-06-08 10:43:02 EDT 
Fixed with 4841ea05b633ccc15a94b9a6202c3f22479031bf.