Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347307 - EPP Bundle-Vendor and Feature providerName change
Summary: EPP Bundle-Vendor and Feature providerName change
Status: RESOLVED FIXED
Alias: None
Product: EPP
Classification: Technology
Component: package content (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4.0 RC3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 08:50 EDT by Markus Knauer CLA
Modified: 2012-06-05 10:48 EDT (History)
3 users (show)

See Also:


Attachments
Bundle-Vendor patch (14.47 KB, patch)
2011-05-26 10:45 EDT, Markus Knauer CLA
no flags Details | Diff
pre-RC3 version screen shot (90.37 KB, image/png)
2011-05-27 09:39 EDT, Markus Knauer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Knauer CLA 2011-05-26 08:50:34 EDT
This is kind of a cosmetical change, but there is a reason behind this request. 

In the EPP project we are using sometimes "Eclipse.org - EPP" as a Bundle-Vendor string in the plugins, sometimes the longer version "Eclipse Packaging Project". The same applies to the providerName in the features. The MPC (which is a sub-project of EPP) uses the longer version only.

This results in two features listed with two icons in the about dialog, both of them are contributed by EPP.

I'd like to change this and propose to harmonize this in all EPP packages to the long format "Eclipse Packaging Project" which is the official name of the project. I hope that complies with the rules of the Simultaneous Release.
Comment 1 Markus Knauer CLA 2011-05-26 10:45:30 EDT
Created attachment 196667 [details]
Bundle-Vendor patch

This patch changes for all existing Indigo packages the

* providerName in the features and the
* Bundle-Vendor in the plugins

to the proposed long form "Eclipse Packaging Project".

I am going to apply this patch to CVS HEAD in a moment (independently from a possible discussion and decision here on the bug) in order to test the changes for RC3 as soon as possible. I'll leave this bug open for further comments.
Comment 2 David Williams CLA 2011-05-26 11:05:18 EDT
This is great ... thanks for pushing on this. 

("Eclipse.org" is soooo old-fashion :)
Comment 3 Markus Knauer CLA 2011-05-26 11:11:17 EDT
Changing to RC3 since it won't go into RC2 unless many people have valid rebuild requests.
Comment 4 Greg Watson CLA 2011-05-27 07:56:32 EDT
Projects will also need to change their vendor strings to "Eclipse Packaging Project" otherwise there will still be two icons: one for the EPP feature and one for the package features.
Comment 5 Markus Knauer CLA 2011-05-27 09:39:18 EDT
Created attachment 196753 [details]
pre-RC3 version screen shot

From my point of view it works as expected, see the attached screen shot of the About dialog with *one* entry for all EPP features. By clicking on this you get the dialog in the bottom that lists all EPP features, in this case the EPP Package feature and the MPC.

(This is not included in the RC2 build, but will be in the first RC3 builds.)
Comment 6 Greg Watson CLA 2011-05-27 10:13:19 EDT
The icon is keyed off both the vendor name and the image name, so if packages provide a different image then you'll still get one icon per package.
Comment 7 Markus Knauer CLA 2012-06-05 10:48:24 EDT
Closing as FIXED. I haven't seen any problems in the Indigo builds (and not in the Juno builds either).