Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347228 - AdapterFactoryEditingDomain.isReadOnly(Resource) should request ATTRIBUTE_READ_ONLY only
Summary: AdapterFactoryEditingDomain.isReadOnly(Resource) should request ATTRIBUTE_REA...
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Edit (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ed Merks CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-25 17:50 EDT by Mario Winterer CLA
Modified: 2011-11-22 05:26 EST (History)
0 users

See Also:

Attachments
Patch that requests ATTRIBUTE_READ_ONLY only (1.24 KB, patch)
2011-05-25 18:02 EDT, Mario Winterer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Winterer CLA 2011-05-25 17:50:42 EDT 
Build Identifier: 20090619-0625

The current implementation of AdapterFactoryEditingDomain.isReadOnly(Resource) fetches all attributes via URIConverter.getAttributes instead of just fetching the attribute ATTRIBUTE_READ_ONLY (using an option map).
This causes additional unnecessary server requests for web resources (http).
(see also URIHandlerImpl.getAttributes(URI, Map) )

Reproducible: Always
Comment 1 Mario Winterer CLA 2011-05-25 18:02:52 EDT 
Created attachment 196613 [details]
Patch that requests ATTRIBUTE_READ_ONLY only

This patch uses the request attributes option (URIConverter.OPTION_REQUESTED_ATTRIBUTES) to narrow the attribute request to URIConverter.ATTRIBUTE_READ_ONLY only.
Comment 2 Ed Merks CLA 2011-10-27 13:03:50 EDT 
The fix is committed to CVS for 2.8.
Comment 3 Ed Merks CLA 2011-11-22 05:26:49 EST 
The changes are available in builds.