347124 – [Wizards] Import Team Project Set page is missing mnemonics for radio buttons (File/URL)

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347124 - [Wizards] Import Team Project Set page is missing mnemonics for radio buttons (File/URL)

Summary: [Wizards] Import Team Project Set page is missing mnemonics for radio buttons...

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	Team (show other bugs)
Version:	3.7
Hardware:	PC Windows XP

Importance:	P3 trivial (vote)
Target Milestone:	3.7 RC3
Assignee:	Malgorzata Janczarska
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-25 05:13 EDT by Tomasz Zarna
Modified:	2011-05-26 01:54 EDT (History)
CC List:	4 users (show)

See Also:

Flags:	pwebster: review+ Szymon.Brandys: review+ daniel_megert: review+ serge: review+

Attachments
Added mnemonics (1.12 KB, patch) 2011-05-25 06:03 EDT, Malgorzata Janczarska	no flags	Details \| Diff
New screenshoot (20.10 KB, image/png) 2011-05-25 06:06 EDT, Malgorzata Janczarska	no flags	Details
Added mnemonics (1.52 KB, patch) 2011-05-25 06:49 EDT, Malgorzata Janczarska	daniel_megert: review+	Details \| Diff
New screenshoot (19.64 KB, image/png) 2011-05-25 06:50 EDT, Malgorzata Janczarska	no flags	Details
New screenshoot (23.50 KB, image/png) 2011-05-25 07:03 EDT, Malgorzata Janczarska	no flags	Details
properly updated screenshot (17.48 KB, image/png) 2011-05-25 07:23 EDT, Tomasz Zarna	no flags	Details
mylyn/context/zip (2.48 KB, application/octet-stream) 2011-05-25 07:23 EDT, Tomasz Zarna	no flags	Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomasz Zarna

2011-05-25 05:13:18 EDT

Caused by bug 162608.

"File name" had "i" as mnemonic. Now neither "File" nor "URL" have one.

Comment 1 Tomasz Zarna

2011-05-25 05:14:10 EDT

Spotted while fixing bug 346447, so when fixed the screenshot from that bug should be updated as well.

Comment 2 Malgorzata Janczarska

2011-05-25 06:03:33 EDT

Created attachment 196527 [details]
Added mnemonics

Comment 3 Malgorzata Janczarska

2011-05-25 06:06:23 EDT

Created attachment 196528 [details]
New screenshoot

Comment 4 Tomasz Zarna

2011-05-25 06:14:33 EDT

(In reply to comment #3)
> Created attachment 196528 [details]
> New screenshoot

The original screenshot has different theme, I wouldn't change that.

Comment 5 Tomasz Zarna

2011-05-25 06:17:42 EDT

(In reply to comment #2)
> Created attachment 196527 [details]
> Added mnemonics

The new mnemonic for "File" (F) is different than the previously used for "File name" (i). I would keep them the same. Don't forget to update copyrights.

Comment 6 Malgorzata Janczarska

2011-05-25 06:49:25 EDT

Created attachment 196531 [details]
Added mnemonics

Comment 7 Malgorzata Janczarska

2011-05-25 06:50:00 EDT

Created attachment 196532 [details]
New screenshoot

Comment 8 Malgorzata Janczarska

2011-05-25 07:03:26 EDT

Created attachment 196535 [details]
New screenshoot

Comment 9 Dani Megert

2011-05-25 07:06:45 EDT

You need 3 review+ for RC3.

The screenshot looks blurred. Did you follow the
http://wiki.eclipse.org/Eclipse_Doc_Style_Guide? Especially:
(*) Display Properties > Appearance > Effects > Use the following method to
smooth edges of screen fonts: Off (Not checked)

+1 for RC3 for the code change.

Comment 10 Tomasz Zarna

2011-05-25 07:23:15 EDT

Created attachment 196537 [details]
properly updated screenshot

Comment 11 Tomasz Zarna

2011-05-25 07:23:21 EDT

Created attachment 196538 [details]
mylyn/context/zip

Comment 12 Paul Webster

2011-05-25 07:40:59 EDT

Looks fine.
PW

Comment 13 Serge Beauchamp

2011-05-25 07:41:20 EDT

I review the fix and it looks good.

Comment 14 Tomasz Zarna

2011-05-25 07:43:35 EDT

Thanks guys! Applied to HEAD. Mnemonics will be available in builds >=20110525-0800.

Comment 15 Dani Megert

2011-05-26 01:54:12 EDT

Verified in I20110525-0800.

Filed bug 347250 for missing link in F1 help.